* [PATCH] ucc_geth_ethtool: Fix typo
@ 2008-04-29 12:02 Joakim Tjernlund
2008-04-29 12:18 ` Li Yang
2008-05-22 18:06 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Joakim Tjernlund @ 2008-04-29 12:02 UTC (permalink / raw)
To: Li Yang, Netdev; +Cc: Joakim Tjernlund
Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode•se>
---
drivers/net/ucc_geth_ethtool.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ucc_geth_ethtool.c b/drivers/net/ucc_geth_ethtool.c
index 9a9622c..a995a3a 100644
--- a/drivers/net/ucc_geth_ethtool.c
+++ b/drivers/net/ucc_geth_ethtool.c
@@ -314,7 +314,7 @@ static void uec_get_strings(struct net_device *netdev, u32 stringset, u8 *buf)
buf += UEC_TX_FW_STATS_LEN * ETH_GSTRING_LEN;
}
if (stats_mode & UCC_GETH_STATISTICS_GATHERING_MODE_FIRMWARE_RX)
- memcpy(buf, tx_fw_stat_gstrings, UEC_RX_FW_STATS_LEN *
+ memcpy(buf, rx_fw_stat_gstrings, UEC_RX_FW_STATS_LEN *
ETH_GSTRING_LEN);
}
--
1.5.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] ucc_geth_ethtool: Fix typo
2008-04-29 12:02 [PATCH] ucc_geth_ethtool: Fix typo Joakim Tjernlund
@ 2008-04-29 12:18 ` Li Yang
2008-05-22 18:06 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Li Yang @ 2008-04-29 12:18 UTC (permalink / raw)
To: Joakim Tjernlund, Netdev
> -----Original Message-----
> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@transmode•se]
> Sent: Tuesday, April 29, 2008 8:03 PM
> To: Li Yang; Netdev
> Cc: Joakim Tjernlund
> Subject: [PATCH] ucc_geth_ethtool: Fix typo
>
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode•se>
Acked-by: Li Yang <leoli@freescale•com>
> ---
> drivers/net/ucc_geth_ethtool.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ucc_geth_ethtool.c
> b/drivers/net/ucc_geth_ethtool.c index 9a9622c..a995a3a 100644
> --- a/drivers/net/ucc_geth_ethtool.c
> +++ b/drivers/net/ucc_geth_ethtool.c
> @@ -314,7 +314,7 @@ static void uec_get_strings(struct
> net_device *netdev, u32 stringset, u8 *buf)
> buf += UEC_TX_FW_STATS_LEN * ETH_GSTRING_LEN;
> }
> if (stats_mode & UCC_GETH_STATISTICS_GATHERING_MODE_FIRMWARE_RX)
> - memcpy(buf, tx_fw_stat_gstrings, UEC_RX_FW_STATS_LEN *
> + memcpy(buf, rx_fw_stat_gstrings, UEC_RX_FW_STATS_LEN *
> ETH_GSTRING_LEN);
> }
>
> --
> 1.5.5.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ucc_geth_ethtool: Fix typo
2008-04-29 12:02 [PATCH] ucc_geth_ethtool: Fix typo Joakim Tjernlund
2008-04-29 12:18 ` Li Yang
@ 2008-05-22 18:06 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-05-22 18:06 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: Li Yang, Netdev
Joakim Tjernlund wrote:
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode•se>
> ---
> drivers/net/ucc_geth_ethtool.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ucc_geth_ethtool.c b/drivers/net/ucc_geth_ethtool.c
> index 9a9622c..a995a3a 100644
> --- a/drivers/net/ucc_geth_ethtool.c
> +++ b/drivers/net/ucc_geth_ethtool.c
> @@ -314,7 +314,7 @@ static void uec_get_strings(struct net_device *netdev, u32 stringset, u8 *buf)
> buf += UEC_TX_FW_STATS_LEN * ETH_GSTRING_LEN;
> }
> if (stats_mode & UCC_GETH_STATISTICS_GATHERING_MODE_FIRMWARE_RX)
> - memcpy(buf, tx_fw_stat_gstrings, UEC_RX_FW_STATS_LEN *
> + memcpy(buf, rx_fw_stat_gstrings, UEC_RX_FW_STATS_LEN *
> ETH_GSTRING_LEN);
still looking for maintainer's ack... seems fairly obvious to me
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-22 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-29 12:02 [PATCH] ucc_geth_ethtool: Fix typo Joakim Tjernlund
2008-04-29 12:18 ` Li Yang
2008-05-22 18:06 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox