From: Patrick McHardy <kaber@trash•net>
To: Joonwoo Park <joonwpark81@gmail•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH 1/5] [VLAN]: Unclassified vlan packet
Date: Tue, 27 May 2008 08:30:23 +0200 [thread overview]
Message-ID: <483BAA7F.6060408@trash.net> (raw)
In-Reply-To: <b25c3fa70805262320h7edb4246wd017261fe7187b88@mail.gmail.com>
Joonwoo Park wrote:
> 2008/5/26 Patrick McHardy <kaber@trash•net>:
>> Joonwoo Park wrote:
>>> To be polite to the PACKET,
>>> Don't kill the unclassified & hardware accelerated vlan packets if netdev
>>> is in promiscuous, set packet type with PACKET_OTHERHOST. Put the vlan tag
>>> into skb->cb for all hardware accelerated vlan packets.
>> Conceptually I think this patch goes in the right direction,
>> one question remaining is when to invalidate the VLAN tag again.
>>
>> The only solution I could come up with is invalidating it in
>> netif_receive_skb() when the receiving device is not a VLAN
>> device and additionally invalidating it in all callers of
>> dev_queue_xmit except VLAN itself, but I would really prefer
>> something less error prone without touching netif_receive_skb().
>>
>> BTW, I already have a patch queued to move the VLAN tag from
>> skb->cb to a seperate skb member to fix the the conflict with
>> qdiscs (this should also allow to use vlan accel through virtual
>> network devices later on). So please don't resend, I'll integrate
>> the patch on top of this change once we find a good spot for
>> invalidation.
>>
>
> Thanks Patrick for reviewing.
> I'll be looking forward to seeing it on the list.
Well, we still need to find a good spot for invalidation.
Suggestions welcome :)
next prev parent reply other threads:[~2008-05-27 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 13:57 [PATCH 1/5] [VLAN]: Unclassified vlan packet Joonwoo Park
2008-05-27 5:40 ` Patrick McHardy
2008-05-27 6:20 ` Joonwoo Park
2008-05-27 6:30 ` Patrick McHardy [this message]
2008-05-27 17:40 ` Joonwoo Park
2008-05-27 17:48 ` Patrick McHardy
2008-05-27 18:36 ` Joonwoo Park
2008-06-01 22:16 ` Joonwoo Park
2008-06-02 12:48 ` Patrick McHardy
2008-07-05 19:40 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483BAA7F.6060408@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=joonwpark81@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox