From: Patrick McHardy <kaber@trash•net>
To: Joonwoo Park <joonwpark81@gmail•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH 1/5] [VLAN]: Unclassified vlan packet
Date: Mon, 02 Jun 2008 14:48:15 +0200 [thread overview]
Message-ID: <4843EC0F.8010300@trash.net> (raw)
In-Reply-To: <b25c3fa70806011516q7ae6c913q9d6e431d664d176e@mail.gmail.com>
Joonwoo Park wrote:
> Patrick,
> Do you mind inserting a new flag to indicate vlan_tag is just for
> af_packet or not into sk_buff?
> I think if flag exists, we can pass vlan_tag to af_packet with just
> modifications of vlan_get_tag(), vlan_put_tag() and
> vlan_tag_present(),
> without patching for invalidation.
I've considered this, but that would mean that we report
the vlan tag for all devices layered on top, which seems
wrong.
For now I think I'm going to temporarily do something like
that so I can continue integrating the remaining patches
and fix it properly later.
next prev parent reply other threads:[~2008-06-02 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 13:57 [PATCH 1/5] [VLAN]: Unclassified vlan packet Joonwoo Park
2008-05-27 5:40 ` Patrick McHardy
2008-05-27 6:20 ` Joonwoo Park
2008-05-27 6:30 ` Patrick McHardy
2008-05-27 17:40 ` Joonwoo Park
2008-05-27 17:48 ` Patrick McHardy
2008-05-27 18:36 ` Joonwoo Park
2008-06-01 22:16 ` Joonwoo Park
2008-06-02 12:48 ` Patrick McHardy [this message]
2008-07-05 19:40 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4843EC0F.8010300@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=joonwpark81@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox