From: David Newall <davidn@davidnewall•com>
To: "Németh Márton" <nm127@freemail•hu>
Cc: Stefan Richter <stefanr@s5r6•in-berlin.de>,
Jeff Garzik <jgarzik@pobox•com>,
netdev@vger•kernel.org, Trivial Patch Monkey <trivial@kernel•org>,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH 1/2] 8139too: clean up spaces and TABs
Date: Sun, 15 Jun 2008 15:51:24 +0930 [thread overview]
Message-ID: <4854B4E4.1060903@davidnewall.com> (raw)
In-Reply-To: <48541165.7050304@freemail.hu>
These patches, which simply play around with white space, are
undesirable, in my opinion. It doesn't make the code better, just
changes the aesthetics to one that's more to your liking, and surely it
makes it less pleasing to others. I see no benefit in such changes, as
opposed to a certain cost and risk, which all changes carry. Every
change requires an expense of other people's brain cycles, if I can put
it that way, and on this sort of change, I sincerely think it's pointless.
Sorry to come down all negative.
prev parent reply other threads:[~2008-06-15 6:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 12:36 [PATCH 1/2] 8139too: clean up spaces and TABs Németh Márton
2008-06-14 13:33 ` Stefan Richter
2008-06-14 18:43 ` Németh Márton
2008-06-14 19:53 ` Stefan Richter
2008-06-14 21:21 ` Ondrej Zary
2008-06-14 21:39 ` Francois Romieu
2008-06-15 7:50 ` Németh Márton
2008-06-15 7:52 ` [PATCH] 8139too: some style cleanups Németh Márton
2008-06-27 6:09 ` Jeff Garzik
2008-06-16 15:07 ` [PATCH 1/2] 8139too: clean up spaces and TABs Stefan Richter
2008-06-16 16:31 ` Stephen Hemminger
2008-06-15 6:21 ` David Newall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4854B4E4.1060903@davidnewall.com \
--to=davidn@davidnewall$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nm127@freemail$(echo .)hu \
--cc=stefanr@s5r6$(echo .)in-berlin.de \
--cc=trivial@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox