From: Jeff Garzik <jgarzik@pobox•com>
To: "Németh Márton" <nm127@freemail•hu>
Cc: Stefan Richter <stefanr@s5r6•in-berlin.de>,
David Newall <davidn@davidnewall•com>,
netdev@vger•kernel.org, Trivial Patch Monkey <trivial@kernel•org>,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] 8139too: some style cleanups
Date: Fri, 27 Jun 2008 02:09:43 -0400 [thread overview]
Message-ID: <48648427.8000606@pobox.com> (raw)
In-Reply-To: <4854CA3E.60208@freemail.hu>
Németh Márton wrote:
> From: Márton Németh <nm127@freemail•hu>
>
> Clean up the following errors and warnings reported by checkpatch.pl:
> + ERROR: Macros with complex values should be enclosed in parenthesis
> + WARNING: __func__ should be used instead of gcc specific __FUNCTION__
> + WARNING: plain inline is preferred over __inline__
> + WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> + WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
>
> The changes were verified with by comparing the "objdump -d 8139too.ko"
> output which is exactly the same for the old and new version in case of
> config CONFIG_8139TOO=m, CONFIG_8139TOO_PIO=n, CONFIG_8139TOO_TUNE_TWISTER=n,
> CONFIG_8139TOO_8129=n, CONFIG_8139_OLD_RX_RESET=n.
> Software versions used: gcc 4.2.3, objdump 2.18.0.20080103, on elf32-i386.
>
> Signed-off-by: Márton Németh <nm127@freemail•hu>
applied, thanks for whittling down the changes to this set
next prev parent reply other threads:[~2008-06-27 6:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 12:36 [PATCH 1/2] 8139too: clean up spaces and TABs Németh Márton
2008-06-14 13:33 ` Stefan Richter
2008-06-14 18:43 ` Németh Márton
2008-06-14 19:53 ` Stefan Richter
2008-06-14 21:21 ` Ondrej Zary
2008-06-14 21:39 ` Francois Romieu
2008-06-15 7:50 ` Németh Márton
2008-06-15 7:52 ` [PATCH] 8139too: some style cleanups Németh Márton
2008-06-27 6:09 ` Jeff Garzik [this message]
2008-06-16 15:07 ` [PATCH 1/2] 8139too: clean up spaces and TABs Stefan Richter
2008-06-16 16:31 ` Stephen Hemminger
2008-06-15 6:21 ` David Newall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48648427.8000606@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=davidn@davidnewall$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nm127@freemail$(echo .)hu \
--cc=stefanr@s5r6$(echo .)in-berlin.de \
--cc=trivial@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox