From: Jeff Garzik <jeff@garzik•org>
To: David Woodhouse <dwmw2@infradead•org>
Cc: e1000-devel@lists•sourceforge.net, netdev@vger•kernel.org,
Auke Kok <auke-jan.h.kok@intel•com>,
Jaswinder Singh <jaswinderlinux@gmail•com>
Subject: Re: [PATCH] firmware: convert e100 driver to request_firmware()
Date: Sun, 15 Jun 2008 13:50:47 -0400 [thread overview]
Message-ID: <48555677.7040209@garzik.org> (raw)
In-Reply-To: <1213522966.26255.433.camel@pmac.infradead.org>
David Woodhouse wrote:
> From: Jaswinder Singh <jaswinderlinux@gmail•com>
>
> Thanks to David Woodhouse for help.
>
> Signed-off-by: Jaswinder Singh <jaswinderlinux@gmail•com>
> Signed-off-by: David Woodhouse <dwmw2@infradead•org>
> ---
> We have assumed that in the no-µcode case, there's no actual _reason_
> for the cb_nop command which e100_setup_ucode() was sending; it's just
> that there was no way for it to simply refrain from sending a command,
> since it returns void.
>
> Abusing the skb parameter for e100_exec_cb() isn't massively pretty, but
> it should work. We could always add a struct firmware * into 'struct
> nic' if people really object.
>
> And finally, we've assumed that aborting is the correct thing to do when
> the µcode can't be loaded. Should we instead just complain and move on?
>
> drivers/net/Kconfig | 8 +
> drivers/net/e100.c | 283 +++++++++++-------------------------
> firmware/Makefile | 2 +
> firmware/WHENCE | 12 ++
> firmware/e100/d101m_ucode.bin.ihex | 38 +++++
> firmware/e100/d101s_ucode.bin.ihex | 38 +++++
> firmware/e100/d102e_ucode.bin.ihex | 38 +++++
> 7 files changed, 222 insertions(+), 197 deletions(-)
> create mode 100644 firmware/e100/d101m_ucode.bin.ihex
> create mode 100644 firmware/e100/d101s_ucode.bin.ihex
> create mode 100644 firmware/e100/d102e_ucode.bin.ihex
NAK - firmware should not be stored in a separate directory from the
driver to which it is intimately tied.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
E1000-devel mailing list
E1000-devel@lists•sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
next prev parent reply other threads:[~2008-06-15 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 9:42 [PATCH] firmware: convert e100 driver to request_firmware() David Woodhouse
2008-06-15 17:50 ` Jeff Garzik [this message]
2008-06-15 17:51 ` David Woodhouse
2008-06-15 18:07 ` Jeff Garzik
2008-06-15 18:34 ` Jaswinder Singh
2008-06-15 18:42 ` David Woodhouse
2008-06-15 19:00 ` Jeff Garzik
2008-06-15 18:44 ` Jeff Garzik
2008-06-15 22:09 ` David Woodhouse
2008-06-15 23:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48555677.7040209@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=auke-jan.h.kok@intel$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=jaswinderlinux@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox