From: Jeff Garzik <jeff@garzik•org>
To: Dave Jones <davej@redhat•com>
Cc: Andrew Morton <akpm@linux-foundation•org>, netdev@vger•kernel.org
Subject: Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam
Date: Tue, 15 Jul 2008 19:03:50 -0400 [thread overview]
Message-ID: <487D2CD6.2070303@garzik.org> (raw)
In-Reply-To: <20080715225410.GB10532@redhat.com>
Dave Jones wrote:
> On Tue, Jul 15, 2008 at 06:18:30PM -0400, Jeff Garzik wrote:
>
> > * [extra project] would be highly useful for MMIO to fall back to PIO,
> > and vice versa, should any resource be unavailable. Sometimes, mainly
> > with MMIO and broken/weird BIOSen, only the PIO PCI BARs will be filled
> > in with useful info.
>
> Hmm, this bit might actually be fairly trivial on top of my other patch..
>
>
> --- linux-2.6.26.noarch/drivers/net/8139too.c~ 2008-07-15 18:49:02.000000000 -0400
> +++ linux-2.6.26.noarch/drivers/net/8139too.c 2008-07-15 18:53:07.000000000 -0400
> @@ -784,6 +784,7 @@ static int __devinit rtl8139_init_board
> DPRINTK("PIO region size == 0x%02X\n", pio_len);
> DPRINTK("MMIO region size == 0x%02lX\n", mmio_len);
>
> +retry:
> if (use_io) {
> /* make sure PCI base addr 0 is PIO */
> if (!(pio_flags & IORESOURCE_IO)) {
> @@ -832,9 +833,10 @@ static int __devinit rtl8139_init_board
> /* ioremap MMIO region */
> ioaddr = pci_iomap(pdev, 1, 0);
> if (ioaddr == NULL) {
> - dev_err(&pdev->dev, "cannot remap MMIO, aborting\n");
> - rc = -EIO;
> - goto err_out;
> + dev_err(&pdev->dev, "cannot remap MMIO, trying PIO\n");
> + pci_release_regions(pdev);
> + use_ui = 1;
> + goto retry;
use_ui? Are you sure this is not not an X.org patch? :)
Yes, seems like that would do the trick quite nicely...
If you would be kind enough to post this as a separate patch from your
use_io patch (since IMO its a separate logical change), that would be
helpful.
Jeff
next prev parent reply other threads:[~2008-07-15 23:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 17:14 odd RTL8139 quirk Dave Jones
2008-04-29 19:37 ` Jeff Garzik
2008-04-29 19:47 ` Dave Jones
2008-04-29 21:56 ` Dave Jones
2008-04-29 22:04 ` Jeff Garzik
2008-04-29 22:10 ` Dave Jones
2008-04-29 22:19 ` Jeff Garzik
2008-04-29 22:28 ` Dave Jones
2008-04-29 22:33 ` Jeff Garzik
2008-04-29 22:32 ` Andrew Morton
2008-04-30 11:13 ` Jeff Garzik
2008-04-30 15:19 ` Stephen Hemminger
2008-05-29 15:06 ` Dave Jones
2008-05-29 15:07 ` [PATCH 1/2] 8139too: Make PIO/MMIO a modparam Dave Jones
2008-05-29 18:18 ` Jeff Garzik
2008-05-29 18:41 ` Dave Jones
2008-05-29 19:01 ` Jeff Garzik
2008-07-15 18:40 ` Dave Jones
2008-07-15 22:18 ` Jeff Garzik
2008-07-15 22:36 ` Dave Jones
2008-07-15 22:55 ` Jeff Garzik
2008-07-15 23:14 ` Dave Jones
2008-07-15 23:31 ` Jeff Garzik
2008-07-15 23:40 ` Dave Jones
2008-07-16 10:03 ` Peter Korsgaard
2008-07-15 22:54 ` Dave Jones
2008-07-15 23:03 ` Jeff Garzik [this message]
2008-07-15 23:15 ` Dave Jones
2008-05-29 15:08 ` [PATCH 2/2] 8139too: Make the OQO2 automatically use PIO mode Dave Jones
2008-05-29 18:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487D2CD6.2070303@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davej@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox