From: Jeff Garzik <jeff@garzik•org>
To: Dave Jones <davej@redhat•com>
Cc: Andrew Morton <akpm@linux-foundation•org>, netdev@vger•kernel.org
Subject: Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam
Date: Tue, 15 Jul 2008 19:31:16 -0400 [thread overview]
Message-ID: <487D3344.8000804@garzik.org> (raw)
In-Reply-To: <20080715231457.GA15266@redhat.com>
Dave Jones wrote:
> On Tue, Jul 15, 2008 at 06:55:42PM -0400, Jeff Garzik wrote:
>
> > > > * [optional] would prefer CONFIG_8139TOO_PIO be handled at compile time,
> > > > by changing the initialized value
> > >
> > > This bit should be taken care of in rtl8139_init_module() at the bottom..
> > >
> > > + /* enable PIO instead of MMIO, if CONFIG_8139TOO_PIO is selected */
> > > +#ifdef CONFIG_8139TOO_PIO
> > > + use_io = 1;
> > > +#endif
> >
> > Right, I was saying I prefer simply to set the initialized value
> > appropriately, and avoid the extra code dollup during module load.
>
> Oh, you mean something like..
>
> static int use_io = CONFIG_8139TOO_PIO;
>
> ?
Sorry for not being specific. I would have guessed the uglier
#ifdef CONFIG_8139TOO_PIO
static int use_io = 1;
#else
static int use_io;
#endif
since CONFIG_8139TOO_PIO doesn't convert to a 1 or 0 neatly in C AFAIK?
But, overall, yes. You get the general idea.
Jeff
next prev parent reply other threads:[~2008-07-15 23:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 17:14 odd RTL8139 quirk Dave Jones
2008-04-29 19:37 ` Jeff Garzik
2008-04-29 19:47 ` Dave Jones
2008-04-29 21:56 ` Dave Jones
2008-04-29 22:04 ` Jeff Garzik
2008-04-29 22:10 ` Dave Jones
2008-04-29 22:19 ` Jeff Garzik
2008-04-29 22:28 ` Dave Jones
2008-04-29 22:33 ` Jeff Garzik
2008-04-29 22:32 ` Andrew Morton
2008-04-30 11:13 ` Jeff Garzik
2008-04-30 15:19 ` Stephen Hemminger
2008-05-29 15:06 ` Dave Jones
2008-05-29 15:07 ` [PATCH 1/2] 8139too: Make PIO/MMIO a modparam Dave Jones
2008-05-29 18:18 ` Jeff Garzik
2008-05-29 18:41 ` Dave Jones
2008-05-29 19:01 ` Jeff Garzik
2008-07-15 18:40 ` Dave Jones
2008-07-15 22:18 ` Jeff Garzik
2008-07-15 22:36 ` Dave Jones
2008-07-15 22:55 ` Jeff Garzik
2008-07-15 23:14 ` Dave Jones
2008-07-15 23:31 ` Jeff Garzik [this message]
2008-07-15 23:40 ` Dave Jones
2008-07-16 10:03 ` Peter Korsgaard
2008-07-15 22:54 ` Dave Jones
2008-07-15 23:03 ` Jeff Garzik
2008-07-15 23:15 ` Dave Jones
2008-05-29 15:08 ` [PATCH 2/2] 8139too: Make the OQO2 automatically use PIO mode Dave Jones
2008-05-29 18:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487D3344.8000804@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davej@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox