* [PATCH] METH: fix MAC address setup
@ 2008-07-30 23:14 Thomas Bogendoerfer
2008-08-07 6:12 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2008-07-30 23:14 UTC (permalink / raw)
To: netdev, linux-mips; +Cc: ralf, jgarzik
Setup of the mac filter lost the upper 16bit of the mac address. This
bug got unconvered by a patch, which fixed the promiscous handling.
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha•franken.de>
---
drivers/net/meth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/meth.c b/drivers/net/meth.c
index 4cb364e..0a97c26 100644
--- a/drivers/net/meth.c
+++ b/drivers/net/meth.c
@@ -100,7 +100,7 @@ static inline void load_eaddr(struct net_device *dev)
DPRINTK("Loading MAC Address: %s\n", print_mac(mac, dev->dev_addr));
macaddr = 0;
for (i = 0; i < 6; i++)
- macaddr |= dev->dev_addr[i] << ((5 - i) * 8);
+ macaddr |= (u64)dev->dev_addr[i] << ((5 - i) * 8);
mace->eth.mac_addr = macaddr;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] METH: fix MAC address setup
2008-07-30 23:14 [PATCH] METH: fix MAC address setup Thomas Bogendoerfer
@ 2008-08-07 6:12 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-08-07 6:12 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: netdev, linux-mips, ralf
Thomas Bogendoerfer wrote:
> Setup of the mac filter lost the upper 16bit of the mac address. This
> bug got unconvered by a patch, which fixed the promiscous handling.
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha•franken.de>
> ---
>
> drivers/net/meth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/meth.c b/drivers/net/meth.c
> index 4cb364e..0a97c26 100644
> --- a/drivers/net/meth.c
> +++ b/drivers/net/meth.c
> @@ -100,7 +100,7 @@ static inline void load_eaddr(struct net_device *dev)
> DPRINTK("Loading MAC Address: %s\n", print_mac(mac, dev->dev_addr));
> macaddr = 0;
> for (i = 0; i < 6; i++)
> - macaddr |= dev->dev_addr[i] << ((5 - i) * 8);
> + macaddr |= (u64)dev->dev_addr[i] << ((5 - i) * 8);
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-07 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-30 23:14 [PATCH] METH: fix MAC address setup Thomas Bogendoerfer
2008-08-07 6:12 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox