From: Sandro Bonazzola <sandro.bonazzola@gmail•com>
To: Pekka Enberg <penberg@cs•helsinki.fi>
Cc: Pavel Machek <pavel@suse•cz>, Greg Kroah-Hartman <greg@kroah•com>,
linux-kernel@vger•kernel.org,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe()
Date: Mon, 26 Jan 2009 21:13:22 +0100 [thread overview]
Message-ID: <497E1962.6000804@gmail.com> (raw)
In-Reply-To: <84144f020901261143o1bb41b76o680c8616a81dc2db@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Pekka Enberg ha scritto:
>>> Ok, with kernel 2.6.8.1, and your patch it seems to work with channel 1, no
>>> encryption, opensystem authentication.
>> So the driver doesn't work in 2.6.29-rc1 but does in 2.6.28.1? I
>> wonder what changed in the networking/wireless stack that broke the
>> winbond driver.... I'm cc'ing netdev even though this is a driver in
>> staging.
Well, I don't know if this can be somehow related to a bug in the driver, but on
my system, after I've unplugged the USB trasnsitter, ksoftirqd/0 begin to use
89% of my CPU time (top). I suspect that there are some issue that should be
fixed somewhere.
> Actually, it's probably me who broke the driver. I think Greg merged
> most of my patches after 2.6.28 came out. Sandro, if you have some
> time, please consider doing git bisect to find out which changeset
> causes the problem.
Well, actually my 2.6.29 copy seems to be broken:
arch/x86/kernel/amd_iommu.o: In function `debugfs_create_size_t':
amd_iommu.c:(.text+0x0): multiple definition of `debugfs_create_size_t'
arch/x86/kernel/kdebugfs.o:kdebugfs.c:(.text+0x0): first defined here
make[1]: *** [arch/x86/kernel/built-in.o] Error 1
make: *** [arch/x86/kernel] Error 2
# git pull
Already up-to-date.
# git status
# On branch master
# Changed but not updated:
# (use "git add <file>..." to update what will be committed)
# (use "git checkout -- <file>..." to discard changes in working directory)
#
# modified: drivers/staging/winbond/wbusb.c
#
no changes added to commit (use "git add" and/or "git commit -a")
I don't know too much how to use git to do what you're asking. I've some years
of experience with svn and cvs but git is quite a new tool for me.
I'll wait a git kernel that compile while I'll try to find out how to do what
you're asking.
I have not so much free time to spend in a checkout / build / test if the test
phase need a kernel reinstall / system reboot. If it's only the driver module I
think I can try to test it for each changeset in a couple of weeks /starting
from the day I know how to bisect :-) ).
- --
Sandro
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkl+GWIACgkQV871CybFezlRXACfQTBrMm2hL9b+o5oU1/6/xZ+f
gaYAnjyyawOFPBPIe/scq5pYupNrRLa3
=d1SV
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2009-01-26 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0901221205400.27341@melkki.cs.Helsinki.FI>
[not found] ` <20090122114237.GA13845@atrey.karlin.mff.cuni.cz>
[not found] ` <4978C812.90702@gmail.com>
[not found] ` <20090122211052.GA1928@elf.ucw.cz>
[not found] ` <4978F47C.6010909@gmail.com>
[not found] ` <4978F3CF.2010301@cs.helsinki.fi>
[not found] ` <497E0F94.8000003@gmail.com>
2009-01-26 19:40 ` [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe() Pekka Enberg
2009-01-26 19:43 ` Pekka Enberg
2009-01-26 20:13 ` Sandro Bonazzola [this message]
2009-01-26 20:22 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497E1962.6000804@gmail.com \
--to=sandro.bonazzola@gmail$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel@suse$(echo .)cz \
--cc=penberg@cs$(echo .)helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox