[PATCH] hso: add new device id's

public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

* [PATCH] hso: add new device id's
@ 2009-02-02 14:59 Filip Aben
       [not found] ` <49870A39.8000806-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Filip Aben @ 2009-02-02 14:59 UTC (permalink / raw)
  To: davem-fT/PcQaiUtIeIZ0/mPfg9Q, gregkh-l3A5Bk7waGM
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

This patch adds a few device id's and removes one which will never be used.

Signed-off-by: Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public•gmane.org>
---



[-- Attachment #2: hso_add_device_ids.patch --]
[-- Type: text/x-patch, Size: 1013 bytes --]

This patch adds a few device id's and removes one which will never be used.

Signed-off-by: Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public•gmane.org>
---
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 0d0fa91..fe98aca 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -455,6 +455,7 @@ static const struct usb_device_id hso_ids[] = {
 	{icon321_port_device(0x0af0, 0xd033)},	/* Icon-322 */
 	{USB_DEVICE(0x0af0, 0x7301)},		/* GE40x */
 	{USB_DEVICE(0x0af0, 0x7361)},		/* GE40x */
+	{USB_DEVICE(0x0af0, 0x7381)},		/* GE40x */
 	{USB_DEVICE(0x0af0, 0x7401)},		/* GI 0401 */
 	{USB_DEVICE(0x0af0, 0x7501)},		/* GTM 382 */
 	{USB_DEVICE(0x0af0, 0x7601)},		/* GE40x */
@@ -462,7 +463,8 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
 	{USB_DEVICE(0x0af0, 0x7361)},
-	{icon321_port_device(0x0af0, 0xd051)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd055)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);

^ permalink raw reply related	[flat|nested] 4+ messages in thread

[parent not found: <49870A39.8000806-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>]

* Re: [PATCH] hso: add new device id's
       [not found] ` <49870A39.8000806-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
@ 2009-02-02 22:02   ` David Miller
       [not found]     ` <20090202.140240.230022378.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2009-02-02 22:02 UTC (permalink / raw)
  To: f.aben-x9gZzRpC1QbQT0dZR+AlfA
  Cc: gregkh-l3A5Bk7waGM, netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

From: Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public•gmane.org>
Date: Mon, 02 Feb 2009 15:59:05 +0100

> This patch adds a few device id's and removes one which will never be used.
> 
> Signed-off-by: Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public•gmane.org>

Why won't 0xaf0/0xd051 ever be used?

You should explain such things in your commit message,
that way I don't have to ask.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <20090202.140240.230022378.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>]

* RE: [PATCH] hso: add new device id's
       [not found]     ` <20090202.140240.230022378.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
@ 2009-02-03  0:26       ` Filip Aben
       [not found]         ` <4ADF55C1EB3643428CD4FAE5C129EF950258CD97-XlSf7ELR9ZHcV2kYEOvnW/lB2ga7rPjFZkel5v8DVj8@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Filip Aben @ 2009-02-03  0:26 UTC (permalink / raw)
  To: David Miller
  Cc: gregkh-l3A5Bk7waGM, netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA



> -----Original Message-----
> From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org]
> Sent: maandag 2 februari 2009 23:03
> To: Filip Aben
> Cc: gregkh-l3A5Bk7waGM@public•gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
> Subject: Re: [PATCH] hso: add new device id's
> 
> From: Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public•gmane.org>
> Date: Mon, 02 Feb 2009 15:59:05 +0100
> 
> > This patch adds a few device id's and removes one which will never
be
> used.
> >
> > Signed-off-by: Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public•gmane.org>
> 
> Why won't 0xaf0/0xd051 ever be used?
> 
> You should explain such things in your commit message,
> that way I don't have to ask.

That ID was used in an internal engineering version of a device and 
will never see commercial light.
Even if this ID will be 'recycled' in the future, which is very
unlikely, 
I don't know what kind of device will be behind it. Therefore it's safer
to remove it.

Regards,

Filip-
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <4ADF55C1EB3643428CD4FAE5C129EF950258CD97-XlSf7ELR9ZHcV2kYEOvnW/lB2ga7rPjFZkel5v8DVj8@public.gmane.org>]

* Re: [PATCH] hso: add new device id's
       [not found]         ` <4ADF55C1EB3643428CD4FAE5C129EF950258CD97-XlSf7ELR9ZHcV2kYEOvnW/lB2ga7rPjFZkel5v8DVj8@public.gmane.org>
@ 2009-02-03  0:33           ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-02-03  0:33 UTC (permalink / raw)
  To: F.Aben-x9gZzRpC1QbQT0dZR+AlfA
  Cc: gregkh-l3A5Bk7waGM, netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

From: "Filip Aben" <F.Aben-x9gZzRpC1QbQT0dZR+AlfA@public•gmane.org>
Date: Tue, 3 Feb 2009 01:26:14 +0100

> > -----Original Message-----
> > From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org]
> > Sent: maandag 2 februari 2009 23:03
> > To: Filip Aben
> > Cc: gregkh-l3A5Bk7waGM@public•gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
> > Subject: Re: [PATCH] hso: add new device id's
> > 
> > Why won't 0xaf0/0xd051 ever be used?
> > 
> > You should explain such things in your commit message,
> > that way I don't have to ask.
> 
> That ID was used in an internal engineering version of a device and 
> will never see commercial light.
> Even if this ID will be 'recycled' in the future, which is very
> unlikely, 
> I don't know what kind of device will be behind it. Therefore it's safer
> to remove it.

Great, please add that information to the commit message
and resend your patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-02-03  0:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-02 14:59 [PATCH] hso: add new device id's Filip Aben
     [not found] ` <49870A39.8000806-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
2009-02-02 22:02   ` David Miller
     [not found]     ` <20090202.140240.230022378.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-02-03  0:26       ` Filip Aben
     [not found]         ` <4ADF55C1EB3643428CD4FAE5C129EF950258CD97-XlSf7ELR9ZHcV2kYEOvnW/lB2ga7rPjFZkel5v8DVj8@public.gmane.org>
2009-02-03  0:33           ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox