* [PATCH 1/1 net-next] s2io: Formatting log message
@ 2009-02-03 12:39 Breno Leitao
2009-02-03 23:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Breno Leitao @ 2009-02-03 12:39 UTC (permalink / raw)
To: sreenivasa.honnur, jeff; +Cc: netdev
S2IO driver is printing dev->name before the name being allocated, which
display eth%d instead of eth0, eth1, etc. Example:
eth%d: Enabling MSIX failed
eth%d: MSI-X requested but failed to enable
This patch just change eth%d to s2io.
Signed-off-by: Breno Leitao <leitao@linux•vnet.ibm.com>
---
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index f5c57c0..a63a496 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -3862,7 +3862,7 @@ static int s2io_enable_msi_x(struct s2io_nic *nic)
ret = pci_enable_msix(nic->pdev, nic->entries, nic->num_entries);
/* We fail init if error or we get less vectors than min required */
if (ret) {
- DBG_PRINT(ERR_DBG, "%s: Enabling MSIX failed\n", nic->dev->name);
+ DBG_PRINT(ERR_DBG, "s2io: Enabling MSI-X failed\n");
kfree(nic->entries);
nic->mac_control.stats_info->sw_stat.mem_freed
+= (nic->num_entries * sizeof(struct msix_entry));
@@ -8009,8 +8009,7 @@ s2io_init_nic(struct pci_dev *pdev, const struct pci_device_id *pre)
if (ret) {
DBG_PRINT(ERR_DBG,
- "%s: MSI-X requested but failed to enable\n",
- dev->name);
+ "s2io: MSI-X requested but failed to enable\n");
sp->config.intr_type = INTA;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 net-next] s2io: Formatting log message
2009-02-03 12:39 [PATCH 1/1 net-next] s2io: Formatting log message Breno Leitao
@ 2009-02-03 23:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-03 23:15 UTC (permalink / raw)
To: leitao; +Cc: sreenivasa.honnur, jeff, netdev
From: Breno Leitao <leitao@linux•vnet.ibm.com>
Date: Tue, 03 Feb 2009 10:39:35 -0200
> S2IO driver is printing dev->name before the name being allocated, which
> display eth%d instead of eth0, eth1, etc. Example:
>
> eth%d: Enabling MSIX failed
> eth%d: MSI-X requested but failed to enable
>
> This patch just change eth%d to s2io.
>
> Signed-off-by: Breno Leitao <leitao@linux•vnet.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-03 23:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-03 12:39 [PATCH 1/1 net-next] s2io: Formatting log message Breno Leitao
2009-02-03 23:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox