* [PATCH] i2400m: remove some pointless conditionals before kfree_skb()
@ 2009-02-25 10:20 Wei Yongjun
2009-02-25 17:56 ` Iñaky Pérez-González
2009-02-27 7:08 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2009-02-25 10:20 UTC (permalink / raw)
To: Inaky Perez-Gonzalez, Jeff Garzik; +Cc: linux-wimax, netdev
Remove some pointless conditionals before kfree_skb().
Signed-off-by: Wei Yongjun <yjwei@cn•fujitsu.com>
---
drivers/net/wimax/i2400m/rx.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c
index 6922022..c62b8c5 100644
--- a/drivers/net/wimax/i2400m/rx.c
+++ b/drivers/net/wimax/i2400m/rx.c
@@ -177,8 +177,7 @@ void i2400m_rx_ctl_ack(struct i2400m *i2400m,
return;
error_waiter_cancelled:
- if (ack_skb)
- kfree_skb(ack_skb);
+ kfree_skb(ack_skb);
error_no_waiter:
spin_unlock_irqrestore(&i2400m->rx_lock, flags);
return;
--
1.5.3.8
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2400m: remove some pointless conditionals before kfree_skb()
2009-02-25 10:20 [PATCH] i2400m: remove some pointless conditionals before kfree_skb() Wei Yongjun
@ 2009-02-25 17:56 ` Iñaky Pérez-González
2009-02-27 7:08 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Iñaky Pérez-González @ 2009-02-25 17:56 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Jeff Garzik, linux-wimax, netdev, wimax
On Wednesday 25 February 2009, Wei Yongjun wrote:
> Remove some pointless conditionals before kfree_skb().
>
Applied to the wimax-next tree, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2400m: remove some pointless conditionals before kfree_skb()
2009-02-25 10:20 [PATCH] i2400m: remove some pointless conditionals before kfree_skb() Wei Yongjun
2009-02-25 17:56 ` Iñaky Pérez-González
@ 2009-02-27 7:08 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2009-02-27 7:08 UTC (permalink / raw)
To: yjwei; +Cc: inaky.perez-gonzalez, jgarzik, linux-wimax, netdev
From: Wei Yongjun <yjwei@cn•fujitsu.com>
Date: Wed, 25 Feb 2009 18:20:29 +0800
> Remove some pointless conditionals before kfree_skb().
>
> Signed-off-by: Wei Yongjun <yjwei@cn•fujitsu.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-27 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 10:20 [PATCH] i2400m: remove some pointless conditionals before kfree_skb() Wei Yongjun
2009-02-25 17:56 ` Iñaky Pérez-González
2009-02-27 7:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox