From: Greg Ungerer <gerg@snapgear•com>
To: Sascha Hauer <s.hauer@pengutronix•de>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] FEC driver: patches for -next
Date: Wed, 15 Apr 2009 22:12:05 +1000 [thread overview]
Message-ID: <49E5CF15.80601@snapgear.com> (raw)
In-Reply-To: <1239795145-27558-1-git-send-email-s.hauer@pengutronix.de>
Hi Sascha,
Sascha Hauer wrote:
> These patches aim to modernize the FEC ethernet driver.
> Greg, can you please confirm that the ifdef in patch 01/12 is indeed unused?
It is used for the CONFIG_M5272 case. The offsets to some registers
are slightly different for the version of the FEC hardware in that
SoC CPU.
Regards
Greg
> The following changes since commit 0882e8dd3aad33eca41696d463bb896e6c8817eb:
> Linus Torvalds (1):
> Linux 2.6.30-rc2
>
> are available in the git repository at:
>
> git://git.pengutronix.de/git/sha/linux-2.6.git fec
>
> Sascha Hauer (12):
> fec: remove unused ifdef
> fec: switch to writel/readl
> fec: do not typedef struct types
> fec: remove unnecessary cast
> fec: Codingstyle cleanups
> fec: refactor set_multicast_list() to make it more readable
> fec: refactor init function
> fec: align receive packets
> fec: remove debugging printks
> fec: switch to net_device_ops
> FEC Buffer rework
> fec: call fec_restart() in fec_open()
>
> drivers/net/fec.c | 897 ++++++++++++++++++++++-------------------------------
> drivers/net/fec.h | 112 ++-----
> 2 files changed, 402 insertions(+), 607 deletions(-)
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear•com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2009-04-15 12:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 11:32 [PATCH] FEC driver: patches for -next Sascha Hauer
2009-04-15 11:32 ` [PATCH 01/12] fec: remove unused ifdef Sascha Hauer
2009-04-15 11:32 ` [PATCH 02/12] fec: switch to writel/readl Sascha Hauer
2009-04-15 11:32 ` [PATCH 03/12] fec: do not typedef struct types Sascha Hauer
2009-04-15 11:32 ` [PATCH 04/12] fec: remove unnecessary cast Sascha Hauer
2009-04-15 11:32 ` [PATCH 05/12] fec: Codingstyle cleanups Sascha Hauer
2009-04-15 11:32 ` [PATCH 06/12] fec: refactor set_multicast_list() to make it more readable Sascha Hauer
2009-04-15 11:32 ` [PATCH 07/12] fec: refactor init function Sascha Hauer
2009-04-15 11:32 ` [PATCH 08/12] fec: align receive packets Sascha Hauer
2009-04-15 11:32 ` [PATCH 09/12] fec: remove debugging printks Sascha Hauer
2009-04-15 11:32 ` [PATCH 10/12] fec: switch to net_device_ops Sascha Hauer
2009-04-15 11:32 ` [PATCH 11/12] FEC Buffer rework Sascha Hauer
2009-04-15 11:32 ` [PATCH 12/12] fec: call fec_restart() in fec_open() Sascha Hauer
2009-04-16 9:38 ` David Miller
2009-04-16 9:38 ` [PATCH 11/12] FEC Buffer rework David Miller
2009-04-17 10:07 ` Greg Ungerer
2009-04-17 10:12 ` Sascha Hauer
2009-04-16 9:37 ` [PATCH 10/12] fec: switch to net_device_ops David Miller
2009-04-16 9:37 ` [PATCH 09/12] fec: remove debugging printks David Miller
2009-04-16 9:37 ` [PATCH 08/12] fec: align receive packets David Miller
2009-04-16 9:37 ` [PATCH 07/12] fec: refactor init function David Miller
2009-04-16 9:37 ` [PATCH 06/12] fec: refactor set_multicast_list() to make it more readable David Miller
2009-04-16 9:36 ` [PATCH 05/12] fec: Codingstyle cleanups David Miller
2009-04-16 9:36 ` [PATCH 04/12] fec: remove unnecessary cast David Miller
2009-04-16 9:36 ` [PATCH 03/12] fec: do not typedef struct types David Miller
2009-04-15 13:11 ` [PATCH 02/12] fec: switch to writel/readl Sascha Hauer
2009-04-16 9:36 ` David Miller
2009-04-15 12:12 ` Greg Ungerer [this message]
2009-04-15 12:55 ` [PATCH] FEC driver: patches for -next Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E5CF15.80601@snapgear.com \
--to=gerg@snapgear$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox