From: Naohiro Ooiwa <nooiwa@miraclelinux•com>
To: mchan@broadcom•com
Cc: netdev@vger•kernel.org
Subject: [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no
Date: Wed, 24 Jun 2009 11:57:31 +0900 [thread overview]
Message-ID: <4A41961B.2090206@miraclelinux.com> (raw)
Hi Michael
I found a little bug.
When configure in ifcfg-eth* is ONBOOT=no,
the behavior of ethtool command is wrong.
# grep ONBOOT /etc/sysconfig/network-scripts/ifcfg-eth2
ONBOOT=no
# ethtool eth2 | tail -n1
Link detected: yes
I think "Link detected" should be "no".
The bnx2 driver should run netif_carrier_off() in initialization
until bnx2_open() is called.
The following is my patch.
It move netif_carrier_off() to bnx2_init_one().
I had already tested this patch. The result is good for me.
Could you please check the my patch ?
Best Regards,
Naohiro Ooiwa
Signed-off-by: Naohiro Ooiwa <nooiwa@meriraclelinux•com>
---
drivers/net/bnx2.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 38f1c33..9eee986 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -6151,8 +6151,6 @@ bnx2_open(struct net_device *dev)
struct bnx2 *bp = netdev_priv(dev);
int rc;
- netif_carrier_off(dev);
-
bnx2_set_power_state(bp, PCI_D0);
bnx2_disable_int(bp);
@@ -8066,6 +8064,9 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (CHIP_NUM(bp) == CHIP_NUM_5709)
dev->features |= NETIF_F_TSO6;
+ /* Should set nocarrier until bnx2_open() is called */
+ netif_carrier_off(dev);
+
if ((rc = register_netdev(dev))) {
dev_err(&pdev->dev, "Cannot register net device\n");
goto error;
--
1.5.4.1
next reply other threads:[~2009-06-24 2:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 2:57 Naohiro Ooiwa [this message]
2009-06-24 3:48 ` [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no Michael Chan
2009-06-24 4:43 ` Naohiro Ooiwa
2009-06-24 5:04 ` Michael Chan
2009-06-24 5:45 ` Naohiro Ooiwa
2009-06-24 7:08 ` David Miller
2009-06-24 7:16 ` David Miller
2009-06-24 8:39 ` Naohiro Ooiwa
2009-06-24 16:43 ` Rick Jones
2009-06-24 16:59 ` Michael Chan
2009-06-24 23:42 ` David Miller
2009-06-24 23:48 ` Michael Chan
2009-06-25 0:12 ` David Miller
2009-06-25 0:25 ` David Miller
2009-06-26 4:30 ` Naohiro Ooiwa
2009-06-29 0:49 ` Naohiro Ooiwa
2009-06-30 14:50 ` Eilon Greenstein
2009-06-30 19:46 ` David Miller
2009-07-02 4:46 ` Naohiro Ooiwa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A41961B.2090206@miraclelinux.com \
--to=nooiwa@miraclelinux$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox