From: Naohiro Ooiwa <nooiwa@miraclelinux•com>
To: David Miller <davem@davemloft•net>
Cc: eilong@broadcom•com, mchan@broadcom•com, rick.jones2@hp•com,
netdev@vger•kernel.org
Subject: Re: [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no
Date: Thu, 02 Jul 2009 13:46:55 +0900 [thread overview]
Message-ID: <4A4C3BBF.8050005@miraclelinux.com> (raw)
In-Reply-To: <20090630.124619.163112912.davem@davemloft.net>
Hi David
I'm sorry for my tactless mail.
I see your comment.
Best Regards,
Naohiro Ooiwa
David Miller wrote:
> From: "Eilon Greenstein" <eilong@broadcom•com>
> Date: Tue, 30 Jun 2009 17:50:16 +0300
>
>> On Sun, 2009-06-28 at 17:49 -0700, Naohiro Ooiwa wrote:
>>> Hi Michael
>>>
>>> Thank you for your comment.
>>>
>>> I tried to create a patch of bnx2x driver.
>>> It's the same fix as bnx2 driver.
>>> Could you please check the my patch ?
>>>
>>> Of cource, I made sure of compile.
>> It is also working as expected. I already made a similar patch based on
>> your bnx2 fix and it looks exactly the same...
>>
>> Thanks!
>>
>>> Signed-off-by: Naohiro Ooiwa <nooiwa@miraclelinux•com>
>> Acked-by: Eilon Greenstein <eilong@broadcom•com>
>
> Applied, but you really need to begin writing proper changelog
> entries when you send patches out. Here is the one I wrote for you
> below. Otherwise a random person looking at this change will have no
> idea the reason for it, nor what it is related to.
>
> ==================================================
> bnx2x: Fix the behavior of ethtool when ONBOOT=no
>
> This is the same fix as commit
> 7959ea254ed18faee41160b1c50b3c9664735967 ("bnx2: Fix the behavior of
> ethtool when ONBOOT=no"), but for bnx2x:
>
> --------------------
> When configure in ifcfg-eth* is ONBOOT=no,
> the behavior of ethtool command is wrong.
>
> # grep ONBOOT /etc/sysconfig/network-scripts/ifcfg-eth2
> ONBOOT=no
> # ethtool eth2 | tail -n1
> Link detected: yes
>
> I think "Link detected" should be "no".
> --------------------
>
> Signed-off-by: Naohiro Ooiwa <nooiwa@miraclelinux•com>
> Acked-by: Eilon Greenstein <eilong@broadcom•com>
> Signed-off-by: David S. Miller <davem@davemloft•net>
>
prev parent reply other threads:[~2009-07-02 4:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 2:57 [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no Naohiro Ooiwa
2009-06-24 3:48 ` Michael Chan
2009-06-24 4:43 ` Naohiro Ooiwa
2009-06-24 5:04 ` Michael Chan
2009-06-24 5:45 ` Naohiro Ooiwa
2009-06-24 7:08 ` David Miller
2009-06-24 7:16 ` David Miller
2009-06-24 8:39 ` Naohiro Ooiwa
2009-06-24 16:43 ` Rick Jones
2009-06-24 16:59 ` Michael Chan
2009-06-24 23:42 ` David Miller
2009-06-24 23:48 ` Michael Chan
2009-06-25 0:12 ` David Miller
2009-06-25 0:25 ` David Miller
2009-06-26 4:30 ` Naohiro Ooiwa
2009-06-29 0:49 ` Naohiro Ooiwa
2009-06-30 14:50 ` Eilon Greenstein
2009-06-30 19:46 ` David Miller
2009-07-02 4:46 ` Naohiro Ooiwa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4C3BBF.8050005@miraclelinux.com \
--to=nooiwa@miraclelinux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eilong@broadcom$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rick.jones2@hp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox