* [PATCH] atlx: duplicate testing of MCAST flag
@ 2009-07-12 23:12 Roel Kluin
2009-07-13 0:04 ` J. K. Cliburn
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-07-12 23:12 UTC (permalink / raw)
To: jcliburn, atl1-devel, Andrew Morton, netdev, David Miller
Fix duplicate testing of MCAST flag
Signed-off-by: Roel Kluin <roel.kluin@gmail•com>
---
I think the first should be UCAST, correct?
diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c
index c734b19..204db96 100644
--- a/drivers/net/atlx/atl2.c
+++ b/drivers/net/atlx/atl2.c
@@ -2071,7 +2071,7 @@ static int atl2_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE))
return -EOPNOTSUPP;
- if (wol->wolopts & (WAKE_MCAST|WAKE_BCAST|WAKE_MCAST))
+ if (wol->wolopts & (WAKE_UCAST | WAKE_BCAST | WAKE_MCAST))
return -EOPNOTSUPP;
/* these settings will always override what we currently have */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] atlx: duplicate testing of MCAST flag
2009-07-12 23:12 [PATCH] atlx: duplicate testing of MCAST flag Roel Kluin
@ 2009-07-13 0:04 ` J. K. Cliburn
2009-07-13 18:03 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: J. K. Cliburn @ 2009-07-13 0:04 UTC (permalink / raw)
To: Roel Kluin; +Cc: atl1-devel, Andrew Morton, netdev, David Miller
On Sun, Jul 12, 2009 at 6:12 PM, Roel Kluin<roel.kluin@gmail•com> wrote:
> Fix duplicate testing of MCAST flag
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail•com>
> ---
> I think the first should be UCAST, correct?
>
> diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c
> index c734b19..204db96 100644
> --- a/drivers/net/atlx/atl2.c
> +++ b/drivers/net/atlx/atl2.c
> @@ -2071,7 +2071,7 @@ static int atl2_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
> if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE))
> return -EOPNOTSUPP;
>
> - if (wol->wolopts & (WAKE_MCAST|WAKE_BCAST|WAKE_MCAST))
> + if (wol->wolopts & (WAKE_UCAST | WAKE_BCAST | WAKE_MCAST))
> return -EOPNOTSUPP;
>
> /* these settings will always override what we currently have */
>
Acked-by: Jay Cliburn <jcliburn@gmail•com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] atlx: duplicate testing of MCAST flag
2009-07-13 0:04 ` J. K. Cliburn
@ 2009-07-13 18:03 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-07-13 18:03 UTC (permalink / raw)
To: jcliburn; +Cc: roel.kluin, atl1-devel, akpm, netdev
From: "J. K. Cliburn" <jcliburn@gmail•com>
Date: Sun, 12 Jul 2009 19:04:20 -0500
> On Sun, Jul 12, 2009 at 6:12 PM, Roel Kluin<roel.kluin@gmail•com> wrote:
>> Fix duplicate testing of MCAST flag
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail•com>
> Acked-by: Jay Cliburn <jcliburn@gmail•com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-13 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-12 23:12 [PATCH] atlx: duplicate testing of MCAST flag Roel Kluin
2009-07-13 0:04 ` J. K. Cliburn
2009-07-13 18:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox