From: Wolfgang Grandegger <wg@grandegger•com>
To: Sascha Hauer <s.hauer@pengutronix•de>
Cc: Socketcan-core@lists•berlios.de,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [PATCH] Add Support for Freescale FlexCAN CAN controller
Date: Mon, 27 Jul 2009 11:25:15 +0200 [thread overview]
Message-ID: <4A6D727B.7030304@grandegger.com> (raw)
In-Reply-To: <20090727062559.GP2714@pengutronix.de>
Sascha Hauer wrote:
> On Fri, Jul 24, 2009 at 04:55:02PM +0200, Wolfgang Grandegger wrote:
>> Hi Sascha,
>>
>> Sascha Hauer wrote:
>>> Hi,
>>>
>>> This patch adds support for the Freescale FlexCAN CAN controller.
>>> The driver has been tested on an i.MX25 SoC with bitrates up to
>>> 1Mbit, remote frames and standard and extenden frames.
>>>
>>> Please review and consider for inclusion.
>> See below...
>>
>>> Sascha
>>>
>>>
>>> >From 94a607390f0d7b181e2ffdfe16a05f3aaca15ab9 Mon Sep 17 00:00:00 2001
>>> From: Sascha Hauer <s.hauer@pengutronix•de>
>>> Date: Tue, 21 Jul 2009 10:47:19 +0200
>>> Subject: [PATCH] Add Flexcan CAN driver
>> The prefix "can:" would be nice here.
>
> Ok, I'll add it next round.
>
>>> This core is found on some Freescale SoCs and also some Coldfire
>>> SoCs. Support for Coldfire is missing though at the moment as
>>> they have an older revision of the core which does not have RX FIFO
>>> support.
>>>
>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix•de>
>>> ---
>>> drivers/net/can/Kconfig | 6 +
>>> drivers/net/can/Makefile | 1 +
>>> drivers/net/can/flexcan.c | 696 +++++++++++++++++++++++++++++++++++++++++++++
>>> 3 files changed, 703 insertions(+), 0 deletions(-)
>>> create mode 100644 drivers/net/can/flexcan.c
>>>
>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
>>> index 33821a8..99c6da4 100644
>>> --- a/drivers/net/can/Kconfig
>>> +++ b/drivers/net/can/Kconfig
[...]
>>> + kfree_skb(skb);
>> Support for echo skb using can_put/get_echo_skb() is missing. It should
>> not be a big deal to add it.
>
> In fact it's not missing, but the hardware is configured to receive its
> own packets, so this isn't needed.
But the user may disable IFF_ECHO, which should be handled somehow.
Wolfgang.
next prev parent reply other threads:[~2009-07-27 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 13:19 [PATCH] Add Support for Freescale FlexCAN CAN controller Sascha Hauer
2009-07-24 14:55 ` Wolfgang Grandegger
2009-07-27 6:25 ` Sascha Hauer
2009-07-27 8:30 ` Wolfgang Grandegger
2009-07-27 9:25 ` Wolfgang Grandegger [this message]
2009-07-27 9:43 ` Oliver Hartkopp
2009-07-27 10:07 ` Wolfgang Grandegger
2009-07-27 10:52 ` Oliver Hartkopp
2009-07-27 12:12 ` Wolfgang Grandegger
2009-07-28 7:40 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6D727B.7030304@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Socketcan-core@lists$(echo .)berlios.de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox