From: Wolfgang Grandegger <wg@grandegger•com>
To: Oliver Hartkopp <socketcan@hartkopp•net>
Cc: Socketcan-core@lists•berlios.de,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [PATCH] Add Support for Freescale FlexCAN CAN controller
Date: Mon, 27 Jul 2009 14:12:11 +0200 [thread overview]
Message-ID: <4A6D999B.9010607@grandegger.com> (raw)
In-Reply-To: <4A6D86F5.7030707@hartkopp.net>
Oliver Hartkopp wrote:
> Wolfgang Grandegger wrote:
>> Oliver Hartkopp wrote:
>>> Wolfgang Grandegger wrote:
>>>> Sascha Hauer wrote:
>>>>> On Fri, Jul 24, 2009 at 04:55:02PM +0200, Wolfgang Grandegger wrote:
>>>> [...]
>>>>>>> + kfree_skb(skb);
>>>>>> Support for echo skb using can_put/get_echo_skb() is missing. It should
>>>>>> not be a big deal to add it.
>>>>> In fact it's not missing, but the hardware is configured to receive its
>>>>> own packets, so this isn't needed.
>>>> But the user may disable IFF_ECHO, which should be handled somehow.
>>> Really?
>>>
>>> IMO IFF_ECHO indicates the capability of the network driver to perform the MAC
>>> layer frame echo on driver level.
>>>
>>> Only when you have a CAN driver that does not have this capability (the 'bad'
>>> non default case) this flag is cleared.
>>>
>>> There is no need to provide a mode that can switch this functionality 'on' and
>>> 'off'. IFF_ECHO is just an indication provided by the driver.
>>>
>>> When the FlexCAN controller can 'receive' a sent frame, so that it reflects
>>> the correct message order on the bus, this is perfect.
>>>
>>> In this case Sascha should set the IFF_ECHO flag and he's done.
>> I thought the user can toggle the IFF_ECHO flag with the "ip" utility,
>> but obviously I'm wrong.
>
> AFAIK the only driver that currently allows to switch this flag is the vcan
> driver - but this is for testing purposes only and can be configured by the
> module commandline.
>
> I assume having the echo functionality runtime configurable is only effort and
> complicates the driver ...
Yep.
Wolfgang.
next prev parent reply other threads:[~2009-07-27 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 13:19 [PATCH] Add Support for Freescale FlexCAN CAN controller Sascha Hauer
2009-07-24 14:55 ` Wolfgang Grandegger
2009-07-27 6:25 ` Sascha Hauer
2009-07-27 8:30 ` Wolfgang Grandegger
2009-07-27 9:25 ` Wolfgang Grandegger
2009-07-27 9:43 ` Oliver Hartkopp
2009-07-27 10:07 ` Wolfgang Grandegger
2009-07-27 10:52 ` Oliver Hartkopp
2009-07-27 12:12 ` Wolfgang Grandegger [this message]
2009-07-28 7:40 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6D999B.9010607@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Socketcan-core@lists$(echo .)berlios.de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=socketcan@hartkopp$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox