* Re: 2.6.31-rc9 breaks gianfar [not found] <20090906072707.GA5699@trillian.comsick.at> @ 2009-09-06 8:41 ` David Miller 2009-09-07 3:21 ` Toru UCHIYAMA 0 siblings, 1 reply; 2+ messages in thread From: David Miller @ 2009-09-06 8:41 UTC (permalink / raw) To: mike; +Cc: linux-kernel, netdev, uchiyama.toru From: Michael Guntsche <mike@it-loops•com> Date: Sun, 6 Sep 2009 09:27:08 +0200 Please also report networking bugs to netdev@vger•kernel.org and CC: the person who commited the problematic commit. > Commit > 38bddf04bcfe661fbdab94888c3b72c32f6873b3 gianfar: gfar_remove needs to call unregister_netdev() > > breaks the build of the gianfar driver because "dev" is undefined in > this function. To quickly test rc9 I changed this to priv->ndev but I do > not know if this is the correct one. Toru-chan, did you even compile test this again current kernels? I'll commit the following fix and push it to Linus, thanks. >From 5db8bfee2dbb3ff28c18868081398fa6e2155053 Mon Sep 17 00:00:00 2001 From: David S. Miller <davem@davemloft•net> Date: Sun, 6 Sep 2009 01:41:02 -0700 Subject: [PATCH] gianfar: Fix build. Reported by Michael Guntsche <mike@it-loops•com> -------------------- Commit 38bddf04bcfe661fbdab94888c3b72c32f6873b3 gianfar: gfar_remove needs to call unregister_netdev() breaks the build of the gianfar driver because "dev" is undefined in this function. To quickly test rc9 I changed this to priv->ndev but I do not know if this is the correct one. -------------------- Signed-off-by: David S. Miller <davem@davemloft•net> --- drivers/net/gianfar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 24f7ca5..a00ec63 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -491,7 +491,7 @@ static int gfar_remove(struct of_device *ofdev) dev_set_drvdata(&ofdev->dev, NULL); - unregister_netdev(dev); + unregister_netdev(priv->ndev); iounmap(priv->regs); free_netdev(priv->ndev); -- 1.6.4.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: 2.6.31-rc9 breaks gianfar 2009-09-06 8:41 ` 2.6.31-rc9 breaks gianfar David Miller @ 2009-09-07 3:21 ` Toru UCHIYAMA 0 siblings, 0 replies; 2+ messages in thread From: Toru UCHIYAMA @ 2009-09-07 3:21 UTC (permalink / raw) To: David Miller; +Cc: mike, linux-kernel, netdev Hi David, I'm sorry.It was my mistake. I will note that it is not never in the future. Thank you for the correction. > From: Michael Guntsche <mike@it-loops•com> > Date: Sun, 6 Sep 2009 09:27:08 +0200 > > Please also report networking bugs to netdev@vger•kernel.org > and CC: the person who commited the problematic commit. > >> Commit >> 38bddf04bcfe661fbdab94888c3b72c32f6873b3 gianfar: gfar_remove needs to call unregister_netdev() >> >> breaks the build of the gianfar driver because "dev" is undefined in >> this function. To quickly test rc9 I changed this to priv->ndev but I do >> not know if this is the correct one. > > Toru-chan, did you even compile test this again current kernels? > > I'll commit the following fix and push it to Linus, thanks. > >>From 5db8bfee2dbb3ff28c18868081398fa6e2155053 Mon Sep 17 00:00:00 2001 > From: David S. Miller <davem@davemloft•net> > Date: Sun, 6 Sep 2009 01:41:02 -0700 > Subject: [PATCH] gianfar: Fix build. > > Reported by Michael Guntsche <mike@it-loops•com> > > -------------------- > Commit > 38bddf04bcfe661fbdab94888c3b72c32f6873b3 gianfar: gfar_remove needs to call unregister_netdev() > > breaks the build of the gianfar driver because "dev" is undefined in > this function. To quickly test rc9 I changed this to priv->ndev but I do > not know if this is the correct one. > -------------------- > > Signed-off-by: David S. Miller <davem@davemloft•net> > --- > drivers/net/gianfar.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c > index 24f7ca5..a00ec63 100644 > --- a/drivers/net/gianfar.c > +++ b/drivers/net/gianfar.c > @@ -491,7 +491,7 @@ static int gfar_remove(struct of_device *ofdev) > > dev_set_drvdata(&ofdev->dev, NULL); > > - unregister_netdev(dev); > + unregister_netdev(priv->ndev); > iounmap(priv->regs); > free_netdev(priv->ndev); > -- ----------------------------------------------- Toru UCHIYAMA uchiyama.toru@jp•fujitsu.com ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-07 3:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090906072707.GA5699@trillian.comsick.at>
2009-09-06 8:41 ` 2.6.31-rc9 breaks gianfar David Miller
2009-09-07 3:21 ` Toru UCHIYAMA
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox