From: Patrick McHardy <kaber@trash•net>
To: "Eric W. Biederman" <ebiederm@xmission•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: ipv4 05/05: add sysctl to accept packets with local source addresses
Date: Fri, 04 Dec 2009 08:55:51 +0100 [thread overview]
Message-ID: <4B18C087.8070804@trash.net> (raw)
In-Reply-To: <m13a3rfa5j.fsf@fess.ebiederm.org>
Eric W. Biederman wrote:
> Patrick McHardy <kaber@trash•net> writes:
>
>> commit 8ec1e0ebe26087bfc5c0394ada5feb5758014fc8
>> Author: Patrick McHardy <kaber@trash•net>
>> Date: Thu Dec 3 12:16:35 2009 +0100
>>
>> ipv4: add sysctl to accept packets with local source addresses
>>
>> Change fib_validate_source() to accept packets with a local source address when
>> the "accept_local" sysctl is set for the incoming inet device. Combined with the
>> previous patches, this allows to communicate between multiple local interfaces
>> over the wire.
>>
>> Signed-off-by: Patrick McHardy <kaber@trash•net>
>>
>
> Obligatory grumble. New binary sysctl. Grumble.
>
> Honestly this might be the one new sysctl that doesn't conflict with
> my sysctl tree. That should merge to Linus sometime this merge cycle
> which will stop exporting this to userspace. So I don't have any
> real complaints. Grumble.
>
> This overloading of sysctl.h for the binary sysctl numbers and
> the index into the perdevice sysctls is something we should probably
> change at some point to keep maintenance a little less confusing.
Yes, unfortunately its currently not possible to add inetdev sysctls
without allocating new numbers.
next prev parent reply other threads:[~2009-12-04 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 11:25 net 00/05: routing based send-to-self implementation Patrick McHardy
2009-12-03 11:25 ` net 01/05: fib_rules: rearrange struct fib_rule Patrick McHardy
2009-12-03 11:25 ` net 02/05: fib_rules: rename ifindex/ifname/FRA_IFNAME to iifindex/iifname/FRA_IIFNAME Patrick McHardy
2009-12-03 11:25 ` net 03/05: fib_rules: add oif classification Patrick McHardy
2009-12-03 11:25 ` net 04/05: fib_rules: allow to delete local rule Patrick McHardy
2009-12-03 11:25 ` ipv4 05/05: add sysctl to accept packets with local source addresses Patrick McHardy
2009-12-04 7:52 ` Eric W. Biederman
2009-12-04 7:55 ` Patrick McHardy [this message]
2009-12-03 20:15 ` net 00/05: routing based send-to-self implementation David Miller
2011-01-14 10:18 ` Kirill Smelkov
2011-01-14 12:22 ` Patrick McHardy
2011-01-14 13:40 ` Jonathan Corbet
2011-01-14 15:02 ` Kirill Smelkov
-- strict thread matches above, loose matches on Subject: below --
2009-11-30 17:55 RFC: " Patrick McHardy
2009-11-30 17:55 ` ipv4 05/05: add sysctl to accept packets with local source addresses Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B18C087.8070804@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox