From: Taku Izumi <izumi.taku@jp•fujitsu.com>
To: Joe Perches <joe@perches•com>
Cc: netdev@vger•kernel.org, Bruce Allan <bruce.w.allan@intel•com>,
"David S. Miller" <davem@davemloft•net>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
John Ronciak <john.ronciak@intel•com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
PJ Waskiewicz <peter.p.waskiewicz.jr@intel•com>,
Koki Sanagi <sanagi.koki@jp•fujitsu.com>,
Kenji Kaneshige <kaneshige.kenji@jp•fujitsu.com>,
chavey@google•com
Subject: Re: [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters
Date: Fri, 22 Jan 2010 17:46:30 +0900 [thread overview]
Message-ID: <4B5965E6.8090109@jp.fujitsu.com> (raw)
In-Reply-To: <1264141501.32383.75.camel@Joe-Laptop.home>
(2010/01/22 15:25), Joe Perches wrote:
> Trivial:
>
> All of the printks without KERN_<level> should be KERN_CONT
>
> For example:
>
>> + printk(KERN_ERR "%-15s ", rname);
>> + for (n = 0; n< 2; n++)
>> + printk("%08x ", __er32(hw, get_regofs(n)));
>> + printk("\n");
>
> This should be:
>
> printk(KERN_ERR etc...)
> for (n = 0...)
> printk(KERN_CONT "%08x ", etc...
> printk(KERN_CONT "\n")
>
> or perhaps written without the for loop
>
> printk(KERN_ERR "%-15s %08x %08x\n",
> name, __er32(hw, get_regofs(0)), __er32(hw, get_regofs(1)));
>
Thank you for good information! I didn't realize that.
I'll rewrite all.
Best regards,
Taku Izumi
next prev parent reply other threads:[~2010-01-22 8:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 5:45 [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters Taku Izumi
2010-01-22 5:48 ` [PATCH v2 1/3] e1000e: " Taku Izumi
2010-01-22 8:48 ` Taku Izumi
2010-02-19 19:19 ` Laurent Chavey
2010-01-22 5:49 ` [PATCH v2 2/3] igb: " Taku Izumi
2010-01-22 8:49 ` Taku Izumi
2010-01-22 5:50 ` [PATCH v2 3/3] ixgbe: " Taku Izumi
2010-01-22 8:50 ` Taku Izumi
2010-01-22 6:25 ` [PATCH v2 0/3] e1000e,igb,ixgbe: " Joe Perches
2010-01-22 8:46 ` Taku Izumi [this message]
2010-01-22 21:54 ` [PATCH v2 0/3] e1000e, igb, ixgbe: " Brandeburg, Jesse
2010-01-26 10:21 ` [PATCH v2 0/3] e1000e,igb,ixgbe: " Taku Izumi
2010-02-17 19:10 ` Brandeburg, Jesse
2010-02-17 19:32 ` Brandeburg, Jesse
2010-02-19 8:16 ` Taku Izumi
2010-02-19 11:20 ` Jeff Kirsher
2010-02-24 19:36 ` Laurent Chavey
2010-02-25 0:24 ` Taku Izumi
2010-02-25 0:30 ` Taku Izumi
2010-02-26 9:05 ` [PATCH v2 0/3] e1000e, igb, ixgbe: " Taku Izumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5965E6.8090109@jp.fujitsu.com \
--to=izumi.taku@jp$(echo .)fujitsu.com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=chavey@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=kaneshige.kenji@jp$(echo .)fujitsu.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
--cc=sanagi.koki@jp$(echo .)fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox