From: Wolfgang Grandegger <wg@grandegger•com>
To: "Pavel B. Cheblakov" <P.B.Cheblakov@inp•nsk.su>
Cc: Socketcan-core@lists•berlios.de, netdev@vger•kernel.org
Subject: Re: [PATCH net-next-2.6] can: add support for CAN interface cards based on the PLX90xx PCI bridge
Date: Sat, 30 Jan 2010 20:04:14 +0100 [thread overview]
Message-ID: <4B6482AE.4060402@grandegger.com> (raw)
In-Reply-To: <4B647F16.9000105@grandegger.com>
Wolfgang Grandegger wrote:
> Hi Pavel,
>
> Pavel B. Cheblakov wrote:
>> From: Pavel Cheblakov <P.B.Cheblakov@inp•nsk.su>
>>
>> This driver is for CAN interface cards based on the PLX90xx PCI bridge.
>> Driver supports now:
>> - Adlink PCI-7841/cPCI-7841 card (http://www.adlinktech.com/)
>> - Adlink PCI-7841/cPCI-7841 SE card
>> - Marathon CAN-bus-PCI card (http://www.marathon.ru/)
>> - TEWS TECHNOLOGIES TPMC810 card (http://www.tews.com/)
>>
>> Signed-off-by: Pavel Cheblakov <P.B.Cheblakov@inp•nsk.su>
>
> We already discussed this patch on the Socketcan mailing list and it's
> OK from my point of view. Please fix the minor issues reported by Daniel
> Baluta. To v2 of the patch you can then add directly my
> "Acked-by: Wolfgang Grandegger <wg@grandegger•com>"
I just realized one more issue. The driver creates section mismatches.
Please use "static DEFINE_PCI_DEVICE_TABLE(plx_pci_tbl)" as, for
example, the ems_pci driver does.
Wolfgang.
next prev parent reply other threads:[~2010-01-30 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 9:45 [PATCH net-next-2.6] can: add support for CAN interface cards based on the PLX90xx PCI bridge Pavel B. Cheblakov
[not found] ` <1264758309-1632-1-git-send-email-chebl-LmX6Lu7C9G7nhuLbLO4Grw@public.gmane.org>
2010-01-29 9:55 ` Daniel Baluta
2010-01-30 18:48 ` Wolfgang Grandegger
2010-01-30 19:04 ` Wolfgang Grandegger [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-29 5:18 Pavel Cheblakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6482AE.4060402@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=P.B.Cheblakov@inp$(echo .)nsk.su \
--cc=Socketcan-core@lists$(echo .)berlios.de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox