From: Marc Kleine-Budde <mkl@pengutronix•de>
To: Sriramakrishnan <srk@ti•com>
Cc: socketcan-core@lists•berlios.de, netdev@vger•kernel.org
Subject: Re: [PATCH 2/2] can: ti hecc module : add platform specific initialization callback.
Date: Mon, 22 Feb 2010 17:00:41 +0100 [thread overview]
Message-ID: <4B82AA29.4090200@pengutronix.de> (raw)
In-Reply-To: <1266845762-7809-1-git-send-email-srk@ti.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
Sriramakrishnan wrote:
> CAN module on AM3517 requires programming of IO expander as part
> of init sequence - to enable CAN PHY. Added platform specific
> init callback to handle this.
Consider giving it a more descriptive name like "phy_switch" and adding
an argument to the function to enable/disable the phy. Put the routine
in the driver's open and close function.
Pleae also update the ti_hecc_platform_data documentation in the top of
ti_hecc.c
Have a look at the at91 for example.
cheers, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2010-02-22 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 13:36 [PATCH 2/2] can: ti hecc module : add platform specific initialization callback Sriramakrishnan
2010-02-22 16:00 ` Marc Kleine-Budde [this message]
2010-02-22 23:47 ` David Miller
[not found] ` <20100222.154741.56894014.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-02-23 14:34 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B82AA29.4090200@pengutronix.de \
--to=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=socketcan-core@lists$(echo .)berlios.de \
--cc=srk@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox