From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>
Cc: srk-l0cyMroinI0@public•gmane.org,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH 2/2] can: ti hecc module : add platform specific initialization callback.
Date: Tue, 23 Feb 2010 15:34:02 +0100 [thread overview]
Message-ID: <4B83E75A.7040101@grandegger.com> (raw)
In-Reply-To: <20100222.154741.56894014.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
David Miller wrote:
> From: Sriramakrishnan <srk-l0cyMroinI0@public•gmane.org>
> Date: Mon, 22 Feb 2010 19:06:02 +0530
>
>> CAN module on AM3517 requires programming of IO expander as part
>> of init sequence - to enable CAN PHY. Added platform specific
>> init callback to handle this.
>>
>> Signed-off-by: Sriramakrishnan <srk-l0cyMroinI0@public•gmane.org>
>> Acked-by: Anant Gole <anantgole-l0cyMroinI0@public•gmane.org>
>
> Please address Wolfgang's feedback comments.
Yes, as Marc suggested, please follow the at91_can.c example using
transceiver_switch.
Wolfgang.
prev parent reply other threads:[~2010-02-23 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 13:36 [PATCH 2/2] can: ti hecc module : add platform specific initialization callback Sriramakrishnan
2010-02-22 16:00 ` Marc Kleine-Budde
2010-02-22 23:47 ` David Miller
[not found] ` <20100222.154741.56894014.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-02-23 14:34 ` Wolfgang Grandegger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B83E75A.7040101@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
--cc=srk-l0cyMroinI0@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox