From: Jeff Garzik <jeff@garzik•org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, gospo@redhat•com,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel•com>
Subject: Re: [ethtool PATCH] ethtool: Support n-tuple filter programming
Date: Wed, 24 Feb 2010 22:41:39 -0500 [thread overview]
Message-ID: <4B85F173.40703@garzik.org> (raw)
In-Reply-To: <20100204075101.16661.95658.stgit@localhost.localdomain>
On 02/04/2010 02:51 AM, Jeff Kirsher wrote:
> From: Peter Waskiewicz<peter.p.waskiewicz.jr@intel•com>
>
> Program underlying ethernet devices with n-tuple flow classification
> filters.
>
> This also adds a new flag to ethtool_flags, allowing n-tuple
> programming to be toggled using the set_flags call.
>
> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel•com>
> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel•com>
> ---
>
> ethtool-copy.h | 35 +++++++++++++
> ethtool.c | 156 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 186 insertions(+), 5 deletions(-)
applied, but two problems remain:
1) you failed to document this in the man page. I will expect a patch
to ethtool.8.
2) you introduced a deviation from the upstream kernel ethtool.h:
--- ethtool-copy.h 2010-02-24 22:39:21.000000000 -0500
+++ ../net-next-2.6/include/linux/ethtool.h 2010-02-24
22:14:43.000000000 -0500
@@ -389,8 +389,6 @@
#define ETHTOOL_RXNTUPLE_ACTION_DROP -1
};
-#define ETHTOOL_MAX_NTUPLE_LIST_ENTRY 1024
-#define ETHTOOL_MAX_NTUPLE_STRING_PER_ENTRY 14
struct ethtool_rx_ntuple {
__u32 cmd;
struct ethtool_rx_ntuple_flow_spec fs;
next prev parent reply other threads:[~2010-02-25 3:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 7:51 [ethtool PATCH] ethtool: Support n-tuple filter programming Jeff Kirsher
2010-02-25 3:41 ` Jeff Garzik [this message]
2010-02-25 7:04 ` Waskiewicz Jr, Peter P
2010-02-25 10:26 ` Jeff Garzik
2010-02-26 1:49 ` Waskiewicz Jr, Peter P
2010-02-26 2:26 ` Jeff Garzik
2010-02-26 5:53 ` David Miller
2010-02-26 6:09 ` Peter P Waskiewicz Jr
2010-02-26 19:59 ` Ben Hutchings
2010-02-26 21:05 ` Jeff Garzik
2010-06-21 19:57 ` Ben Hutchings
2010-06-21 20:31 ` Peter P Waskiewicz Jr
2010-06-21 20:49 ` Mitchell Erblich
2010-06-22 6:42 ` Peter P Waskiewicz Jr
2010-06-22 11:45 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B85F173.40703@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox