From: Jeff Garzik <jeff@garzik•org>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel•com>
Cc: davem@davemloft•net, "Kirsher,
Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"gospo@redhat•com" <gospo@redhat•com>
Subject: Re: [ethtool PATCH] ethtool: Support n-tuple filter programming
Date: Thu, 25 Feb 2010 21:26:38 -0500 [thread overview]
Message-ID: <4B87315E.4080905@garzik.org> (raw)
In-Reply-To: <Pine.WNT.4.64.1002251739130.51452@ppwaskie-MOBL2.amr.corp.intel.com>
On 02/25/2010 08:49 PM, Waskiewicz Jr, Peter P wrote:
> On Wed, 24 Feb 2010, Jeff Garzik wrote:
>
>> On 02/04/2010 02:51 AM, Jeff Kirsher wrote:
>>> From: Peter Waskiewicz<peter.p.waskiewicz.jr@intel•com>
>>>
>>> Program underlying ethernet devices with n-tuple flow classification
>>> filters.
>>>
>>> This also adds a new flag to ethtool_flags, allowing n-tuple
>>> programming to be toggled using the set_flags call.
>>>
>>> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel•com>
>>> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel•com>
>>> ---
>>>
>>> ethtool-copy.h | 35 +++++++++++++
>>> ethtool.c | 156 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>>> 2 files changed, 186 insertions(+), 5 deletions(-)
>>
>> applied, but two problems remain:
>>
>> 1) you failed to document this in the man page. I will expect a patch
>> to ethtool.8.
>>
>> 2) you introduced a deviation from the upstream kernel ethtool.h:
>
> The way I've come up with to fix this is less intrusive than I want, but I
> think it's right way to do it. The intent wasn't to have ethtool
> (userspace) enforce how many filters could be returned. What it should do
> is get the number of strings through drvinfo to make the proper memory
> allocation.
>
> What I need to change is the drvinfo struct in the kernel to include the
> ethtool strings field, returned from get_sset_count(). Then I can pull
> that into userspace and make the correct memory allocation, then call
> get_rx_ntuple().
I would say we need a ETHTOOL_GSTRINGS_COUNT rather than expanding
drvinfo anymore... but yeah, expanding drvinfo would work too.
> This will require a small kernel change. Will something like this be
> pulled in at this point, given that 2.6.33 just released?
The n-tuple stuff is not in 2.6.33's ethtool interface, so it hasn't
actually made it into a released kernel at this point.
It seems reasonable for 2.6.34 to either add ETHTOOL_GSTRINGS_COUNT or
update drvinfo. Even if net-next has already been pulled into
post-2.6.33 merge window, that would IMO qualify as a reasonable
interface bugfix to get upstream. The ethtool n-tuple ABI is not locked
into stone until 2.6.34 is released by Linus.
Jeff
next prev parent reply other threads:[~2010-02-26 2:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 7:51 [ethtool PATCH] ethtool: Support n-tuple filter programming Jeff Kirsher
2010-02-25 3:41 ` Jeff Garzik
2010-02-25 7:04 ` Waskiewicz Jr, Peter P
2010-02-25 10:26 ` Jeff Garzik
2010-02-26 1:49 ` Waskiewicz Jr, Peter P
2010-02-26 2:26 ` Jeff Garzik [this message]
2010-02-26 5:53 ` David Miller
2010-02-26 6:09 ` Peter P Waskiewicz Jr
2010-02-26 19:59 ` Ben Hutchings
2010-02-26 21:05 ` Jeff Garzik
2010-06-21 19:57 ` Ben Hutchings
2010-06-21 20:31 ` Peter P Waskiewicz Jr
2010-06-21 20:49 ` Mitchell Erblich
2010-06-22 6:42 ` Peter P Waskiewicz Jr
2010-06-22 11:45 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B87315E.4080905@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox