From: Jeff Garzik <jeff@garzik•org>
To: David Miller <davem@davemloft•net>
Cc: jeffrey.t.kirsher@intel•com, netdev@vger•kernel.org,
gospo@redhat•com, peter.p.waskiewicz.jr@intel•com
Subject: Re: [net-next-2.6 PATCH] ethtool: Add n-tuple string length to drvinfo and return it
Date: Fri, 26 Feb 2010 08:05:19 -0500 [thread overview]
Message-ID: <4B87C70F.8060403@garzik.org> (raw)
In-Reply-To: <20100226.042027.250812962.davem@davemloft.net>
On 02/26/2010 07:20 AM, David Miller wrote:
> From: Jeff Kirsher<jeffrey.t.kirsher@intel•com>
> Date: Fri, 26 Feb 2010 03:54:20 -0800
>
>> From: Peter Waskiewicz<peter.p.waskiewicz.jr@intel•com>
>>
>> The drvinfo struct should include the number of strings that
>> get_rx_ntuple will return. It will be variable if an underlying
>> driver implements its own get_rx_ntuple routine, so userspace
>> needs to know how much data is coming.
>>
>> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel•com>
>> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel•com>
>
> Applied.
NAK. Did you even read the patch?
We don't increase the size of struct ethtool_drvinfo, _especially_ by
sticking struct members into the middle of the struct.
What do you think 'reserved' is for???
Jeff
next prev parent reply other threads:[~2010-02-26 13:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 11:54 [net-next-2.6 PATCH] ethtool: Add n-tuple string length to drvinfo and return it Jeff Kirsher
2010-02-26 12:20 ` David Miller
2010-02-26 13:05 ` Jeff Garzik [this message]
2010-02-26 13:11 ` David Miller
2010-02-26 20:08 ` Peter P Waskiewicz Jr
2010-02-26 13:44 ` [PATCH] " Jeff Garzik
2010-02-26 13:56 ` Jeff Garzik
2010-02-26 13:59 ` Jeff Garzik
2010-02-26 23:49 ` Peter P Waskiewicz Jr
2010-02-27 6:31 ` Jeff Garzik
2010-02-27 7:25 ` Jeff Garzik
2010-02-27 20:28 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B87C70F.8060403@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox