From: Jeff Garzik <jeff@garzik•org>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH 2/2] sky2: add support for receive hashing
Date: Thu, 22 Apr 2010 21:32:26 -0400 [thread overview]
Message-ID: <4BD0F8AA.2060700@garzik.org> (raw)
In-Reply-To: <20100422234319.149785036@vyatta.com>
On 04/22/2010 07:42 PM, Stephen Hemminger wrote:
> +static int sky2_set_flags(struct net_device *dev, u32 data)
> +{
> + struct sky2_port *sky2 = netdev_priv(dev);
> +
> + if (data& ETH_FLAG_LRO)
> + return -EOPNOTSUPP;
> +
> + if (data& ETH_FLAG_NTUPLE)
> + return -EOPNOTSUPP;
Minor nit: you don't need separate tests for each bit.
Jeff
next prev parent reply other threads:[~2010-04-23 1:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100422234255.150547953@vyatta.com>
2010-04-22 23:42 ` [PATCH 1/2] sky2: size status ring based on Tx/Rx ring Stephen Hemminger
2010-04-23 1:33 ` David Miller
2010-04-22 23:42 ` [PATCH 2/2] sky2: add support for receive hashing Stephen Hemminger
2010-04-23 0:02 ` David Miller
2010-04-23 1:32 ` Jeff Garzik [this message]
2010-04-24 23:22 ` [PATCH 2/2] sky2: add support for receive hashing (v3) Stephen Hemminger
2010-04-25 3:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD0F8AA.2060700@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox