From: Jeff Garzik <jeff@garzik•org>
To: davem@davemloft•net, romieu@fr•zoreil.com, netdev@vger•kernel.org
Subject: Re: [Patch]r8169: remove unnecessary cast of readl()'s return value
Date: Sun, 30 May 2010 13:36:12 -0400 [thread overview]
Message-ID: <4C02A20C.5010007@garzik.org> (raw)
In-Reply-To: <20100530122606.GC1146@host-a-55.ustcsz.edu.cn>
On 05/30/2010 08:26 AM, Junchang Wang wrote:
> readl() returns a 32-bit integer on all platforms.
> There is no need to cast its return value.
>
> Signed-off-by: Junchang Wang<junchangwang@gmail•com>
> ---
> drivers/net/r8169.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 217e709..ca93cdf 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -88,7 +88,7 @@ static const int multicast_filter_limit = 32;
> #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
> #define RTL_R8(reg) readb (ioaddr + (reg))
> #define RTL_R16(reg) readw (ioaddr + (reg))
> -#define RTL_R32(reg) ((unsigned long) readl (ioaddr + (reg)))
> +#define RTL_R32(reg) readl (ioaddr + (reg))
Ditto last email: have you verified this matches all arch's definition
of readl()?
Jeff
next prev parent reply other threads:[~2010-05-30 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 12:26 [Patch]r8169: remove unnecessary cast of readl()'s return value Junchang Wang
2010-05-30 17:36 ` Jeff Garzik [this message]
2010-05-31 7:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C02A20C.5010007@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox