public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Andrew Gallatin <gallatin@myri•com>
To: Stanislaw Gruszka <sgruszka@redhat•com>
Cc: netdev@vger•kernel.org, Amerigo Wang <amwang@redhat•com>,
	Brice Goglin <brice@myri•com>
Subject: Re: [PATCH -next] myri10ge: clear NETIF_F_LRO bit directly
Date: Tue, 29 Jun 2010 11:44:14 -0400	[thread overview]
Message-ID: <4C2A14CE.3090502@myri.com> (raw)
In-Reply-To: <20100629163731.1d174b07@dhcp-lab-109.englab.brq.redhat.com>

Stanislaw Gruszka wrote:
> Do not use ethtool_op_set_flags() to clear one bit in ->features.
> Inform user about disabling LRO.

Thanks.. That simplifies things nicely.  But was
direct manipulation of netdev->features ever discouraged,
or has my use of ethtool_op_{get,set}_flags() to manipulate
the features always been complete overkill?

> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat•com>

Acked-by: Andrew J. Gallatin <gallatin@myri•com>


Thanks,

Drew

next prev parent reply	other threads:[~2010-06-29 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 14:37 [PATCH -next] myri10ge: clear NETIF_F_LRO bit directly Stanislaw Gruszka
2010-06-29 15:44 ` Andrew Gallatin [this message]
2010-06-30 11:26   ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2A14CE.3090502@myri.com \
    --to=gallatin@myri$(echo .)com \
    --cc=amwang@redhat$(echo .)com \
    --cc=brice@myri$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=sgruszka@redhat$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox