From: Pavel Emelyanov <xemul@parallels•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] ip_gre: fix fallback tunnel setup
Date: Thu, 28 Oct 2010 23:29:10 +0400 [thread overview]
Message-ID: <4CC9CF06.1090806@parallels.com> (raw)
In-Reply-To: <1288293079.2711.19.camel@edumazet-laptop>
On 10/28/2010 11:11 PM, Eric Dumazet wrote:
> Le jeudi 28 octobre 2010 à 20:47 +0200, Eric Dumazet a écrit :
>> Le jeudi 28 octobre 2010 à 11:41 -0700, David Miller a écrit :
>>> I am still able to revert this I think without screwing up
>>> publicly visible history, so I will double check and do the
>>> revert if I can.
>>
>> Cool, I'll provide a patch in a couple of minutes, when tested.
>>
>
> I believe the right fix is this one, Pavel what do you think ?
Indeed. I missed the fact, that the gre driver uses ndo_init for
all devices including the fb one :(
Acked-by: Pavel Emelyanov <xemul@openvz•org>
> With your patch, we allocate the per_cpu data twice for the fallback
> tunnel, thus leaking memory.
Yup...
> Thanks
next prev parent reply other threads:[~2010-10-28 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 16:07 [PATCH] ip_gre: fix percpu stats accounting Pavel Emelyanov
2010-10-28 16:33 ` Eric Dumazet
2010-10-28 17:29 ` David Miller
2010-10-28 18:38 ` Eric Dumazet
2010-10-28 18:41 ` David Miller
2010-10-28 18:47 ` Eric Dumazet
2010-10-28 18:49 ` David Miller
2010-10-28 19:11 ` [PATCH] ip_gre: fix fallback tunnel setup Eric Dumazet
2010-10-28 19:29 ` Pavel Emelyanov [this message]
2010-10-28 19:34 ` Eric Dumazet
2010-10-30 23:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC9CF06.1090806@parallels.com \
--to=xemul@parallels$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox