From: "Oleg V. Ukhno" <olegu@yandex-team•ru>
To: John Fastabend <john.r.fastabend@intel•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Jay Vosburgh <fubar@us•ibm.com>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] bonding: added 802.3ad round-robin hashing policy for single TCP session balancing
Date: Sat, 15 Jan 2011 02:12:12 +0300 [thread overview]
Message-ID: <4D30D84C.6000801@yandex-team.ru> (raw)
In-Reply-To: <4D30ADB3.7010509@intel.com>
John Fastabend wrote:
>
> I think you want this patch against net-next not 2.6.37.
This patch is against 2.6.37-git11 and I've tried to apply it to
net-next - it applied ok
>
> Oleg, sorry but I don't follow. If this is simply sending every next packet
> via "next" slave interface how are packets not going to get out of order? If
> the links have different RTT this would seem problematic.
>
> Have you considered using multipath at the block layer? This is how I generally
> handle load balancing over iSCSI/FCoE and it works reasonably well.
>
> see ./drivers/md/dm-mpath.c
John, the first solution I was using a long time for ISCSI load
balancing was multipath. But there are some problems with dm-multipath:
- it is slow(I am using ISCSI for Oracle , so I need to minimize latency)
- it handles any link failures bad, because of it's command queue
limitation(all queued commands above 32 are discarded in case of path
failure, as I remember)
- it performs very bad when there are many devices and maтy paths(I was
unable to utilize more that 2Gbps of 4 even with 100 disks with 4 paths
per each disk)
My patch won't work correct when slave links have different RTT, this is
true - it is usable only within one ethernet segment with equal/near
equal RTT. This is it's limitation.
>> +static int bond_xmit_hash_policy_rr(struct sk_buff *skb,
>> + struct net_device *bond_dev, int count)
>
> Here's one reason why this won't work on net-next-2.6.
>
> int (*xmit_hash_policy)(struct sk_buff *, int);
Thank you, I've missed that change.
>
>
> Thanks,
> John
>
--
Best reagrds,
Oleg Ukhno
next prev parent reply other threads:[~2011-01-14 23:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 19:07 [PATCH] bonding: added 802.3ad round-robin hashing policy for single TCP session balancing Oleg V. Ukhno
2011-01-14 20:10 ` John Fastabend
2011-01-14 23:12 ` Oleg V. Ukhno [this message]
2011-01-14 20:13 ` Jay Vosburgh
2011-01-14 22:51 ` Oleg V. Ukhno
2011-01-15 0:05 ` Jay Vosburgh
2011-01-15 12:11 ` Oleg V. Ukhno
2011-01-18 3:16 ` John Fastabend
2011-01-18 12:40 ` Oleg V. Ukhno
2011-01-18 14:54 ` Nicolas de Pesloüan
2011-01-18 15:28 ` Oleg V. Ukhno
2011-01-18 16:24 ` Nicolas de Pesloüan
2011-01-18 16:57 ` Oleg V. Ukhno
2011-01-18 20:24 ` Jay Vosburgh
2011-01-18 21:20 ` Nicolas de Pesloüan
2011-01-19 1:45 ` Jay Vosburgh
2011-01-18 22:22 ` Oleg V. Ukhno
2011-01-19 16:13 ` Oleg V. Ukhno
2011-01-19 20:12 ` Nicolas de Pesloüan
2011-01-21 13:55 ` Oleg V. Ukhno
2011-01-22 12:48 ` Nicolas de Pesloüan
2011-01-24 19:32 ` Oleg V. Ukhno
2011-01-29 2:28 ` Jay Vosburgh
2011-02-01 16:25 ` Oleg V. Ukhno
2011-02-02 17:30 ` Jay Vosburgh
2011-02-02 9:54 ` Nicolas de Pesloüan
2011-02-02 17:57 ` Jay Vosburgh
2011-02-03 14:54 ` Oleg V. Ukhno
2011-01-18 17:56 ` Kirill Smelkov
2011-01-18 16:41 ` John Fastabend
2011-01-18 17:21 ` Oleg V. Ukhno
2011-01-14 20:41 ` Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D30D84C.6000801@yandex-team.ru \
--to=olegu@yandex-team$(echo .)ru \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox