From: "Oleg V. Ukhno" <olegu@yandex-team•ru>
To: Jay Vosburgh <fubar@us•ibm.com>
Cc: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail•com>,
"John Fastabend" <john.r.fastabend@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] bonding: added 802.3ad round-robin hashing policy for single TCP session balancing
Date: Thu, 03 Feb 2011 17:54:38 +0300 [thread overview]
Message-ID: <4D4AC1AE.70809@yandex-team.ru> (raw)
In-Reply-To: <32505.1296669453@death>
On 02/02/2011 08:57 PM, Jay Vosburgh wrote:
> Nicolas de Pesloüan<nicolas.2p.debian@gmail•com> wrote:
>> I just propose the following option and option values : "src_mac_select"
>> (instead of mac_select), with "default" and "slave_mac" (instead of
>> slave_src_mac) as possible values. In the future, we might need a
>> "dst_mac_select" option... :-)
>
> I originally thought of using the nomenclature you propose; my
> thinking for doing it the way I ended up with is to minimize the number
> of tunable knobs that bonding has (so, the dst_mac would be a setting
> for mac_select). That works as long as there aren't a lot of settings
> that would be turned on simultaneously, since each combination would
> have to be a separate option, or the options parser would have to handle
> multiple settings (e.g., mac_select=src+dst or something like that).
>
> Anyway, after thinking about it some more, in the long run it's
> probably safer to separate these two, so, Oleg, use the above naming
> ("src_mac_select" with "default" and "slave_mac").
>
>> Also, are there any risks that this kind of session load-balancing won't
>> properly cooperate with multiqueue (as explained in "Overriding
>> Configuration for Special Cases" in Documentation/networking/bonding.txt)?
>> I think it is important to ensure we keep the ability to fine tune the
>> egress path selection
>
> I think the logic for the mac_select (or src_mac_select or
> whatever) just has to be done last, after the slave selection is done by
> the multiqueue stuff. That's probably a good tidbit to put in the
> documentation as well.
>
> -J
>
> ---
> -Jay Vosburgh, IBM Linux Technology Center, fubar@us•ibm.com
Thank everyone for comments,
I'll resubmit modified patch after it is ready and tested, in about a
week or two I think.
Oleg
>
--
Best regards,
Oleg Ukhno
next prev parent reply other threads:[~2011-02-03 14:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 19:07 [PATCH] bonding: added 802.3ad round-robin hashing policy for single TCP session balancing Oleg V. Ukhno
2011-01-14 20:10 ` John Fastabend
2011-01-14 23:12 ` Oleg V. Ukhno
2011-01-14 20:13 ` Jay Vosburgh
2011-01-14 22:51 ` Oleg V. Ukhno
2011-01-15 0:05 ` Jay Vosburgh
2011-01-15 12:11 ` Oleg V. Ukhno
2011-01-18 3:16 ` John Fastabend
2011-01-18 12:40 ` Oleg V. Ukhno
2011-01-18 14:54 ` Nicolas de Pesloüan
2011-01-18 15:28 ` Oleg V. Ukhno
2011-01-18 16:24 ` Nicolas de Pesloüan
2011-01-18 16:57 ` Oleg V. Ukhno
2011-01-18 20:24 ` Jay Vosburgh
2011-01-18 21:20 ` Nicolas de Pesloüan
2011-01-19 1:45 ` Jay Vosburgh
2011-01-18 22:22 ` Oleg V. Ukhno
2011-01-19 16:13 ` Oleg V. Ukhno
2011-01-19 20:12 ` Nicolas de Pesloüan
2011-01-21 13:55 ` Oleg V. Ukhno
2011-01-22 12:48 ` Nicolas de Pesloüan
2011-01-24 19:32 ` Oleg V. Ukhno
2011-01-29 2:28 ` Jay Vosburgh
2011-02-01 16:25 ` Oleg V. Ukhno
2011-02-02 17:30 ` Jay Vosburgh
2011-02-02 9:54 ` Nicolas de Pesloüan
2011-02-02 17:57 ` Jay Vosburgh
2011-02-03 14:54 ` Oleg V. Ukhno [this message]
2011-01-18 17:56 ` Kirill Smelkov
2011-01-18 16:41 ` John Fastabend
2011-01-18 17:21 ` Oleg V. Ukhno
2011-01-14 20:41 ` Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4AC1AE.70809@yandex-team.ru \
--to=olegu@yandex-team$(echo .)ru \
--cc=fubar@us$(echo .)ibm.com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.2p.debian@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox