From: Michael Smith <msmith@cbnco•com>
To: netdev@vger•kernel.org
Subject: Re: [PATCH] Disable rp_filter for IPsec packets
Date: Mon, 14 Mar 2011 18:11:24 -0400 [thread overview]
Message-ID: <4D7E928C.1030707@cbnco.com> (raw)
In-Reply-To: <20110314.144156.245399355.davem@davemloft.net>
David Miller wrote:
>> What would be a less costly way to pass it? Could I just hand it the
>> whole skb?
>
> I don't see how passing a pointer is better than passing an interger.
> In both cases you're adding an extra argument to the function.
Yeah, I was thinking an sk_buff could replace the mark parameter,
possibly dev, maybe saddr, daddr, and tos too. On the other hand I can't
think of anything less onerous than an extra stack argument - unless
fib_validate_source() didn't exist at all.
> I was trying to get you to think out of the box and come up with
> something clever, but that isn't working. :-)
Yes, I got that, but I don't know what you are looking for, and don't
expect to succeed by trying something else at random.
> In short, fib_validate_source() is nothing but completely unnecessary
> overhead in the common case.
I'm not entitled to an opinion about fib_validate_source(). It feels
like it might be trying to do one too many things. If it were my code I
might split the RPF out from the spec_dst calculation, move the whole
lot into net/ipv4/route.c, and only do the fib_lookup() if RPF is
enabled or CONFIG_IP_ROUTE_CLASSID (i.e. we need to know the itag).
If that makes sense I'll give it a shot, but beware, I don't even know
what an itag is, and I don't see documentation for CONFIG_IP_ROUTE_CLASSID.
Thanks,
Mike
next prev parent reply other threads:[~2011-03-14 22:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 21:14 [PATCH] Disable rp_filter for IPsec packets Michael Smith
2011-03-14 21:25 ` David Miller
2011-03-14 21:29 ` Michael Smith
2011-03-14 21:41 ` David Miller
2011-03-14 22:11 ` Michael Smith [this message]
2011-03-14 22:14 ` David Miller
2011-03-14 22:23 ` Michael Smith
2011-03-14 22:27 ` David Miller
2011-03-15 23:21 ` Michael Smith
2011-03-15 23:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7E928C.1030707@cbnco.com \
--to=msmith@cbnco$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox