From: Michael Smith <msmith@cbnco•com>
To: netdev@vger•kernel.org
Subject: Re: [PATCH] Disable rp_filter for IPsec packets
Date: Mon, 14 Mar 2011 18:23:20 -0400 [thread overview]
Message-ID: <4D7E9558.7030102@cbnco.com> (raw)
In-Reply-To: <20110314.151424.212690587.davem@davemloft.net>
David Miller wrote:
> Existing arguments might be large enough to carry more than one piece
> of information :-)
If it's encoded into another argument, would there be more overhead from
bit-shifting it out than you'd save by losing an argument?
>> I might split the RPF out from the spec_dst calculation, move the
>> whole lot into net/ipv4/route.c, and only do the fib_lookup() if RPF
>> is enabled or CONFIG_IP_ROUTE_CLASSID (i.e. we need to know the itag).
>
> Can't split two two things up, because spec_dst is a product of the
> reverse FIB lookup, in the form of FIB_RES_PREFSRC().
True, but the result of the reverse FIB lookup could be passed around.
Mike
next prev parent reply other threads:[~2011-03-14 22:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 21:14 [PATCH] Disable rp_filter for IPsec packets Michael Smith
2011-03-14 21:25 ` David Miller
2011-03-14 21:29 ` Michael Smith
2011-03-14 21:41 ` David Miller
2011-03-14 22:11 ` Michael Smith
2011-03-14 22:14 ` David Miller
2011-03-14 22:23 ` Michael Smith [this message]
2011-03-14 22:27 ` David Miller
2011-03-15 23:21 ` Michael Smith
2011-03-15 23:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7E9558.7030102@cbnco.com \
--to=msmith@cbnco$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox