public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: Jan Altenberg <jan-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>
Cc: "Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org"
	<Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org>,
	"netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	"b.spranger-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org"
	<b.spranger-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>
Subject: Re: [PATCH] can: c_can: Fix tx_bytes accounting
Date: Thu, 24 Mar 2011 11:00:33 +0100	[thread overview]
Message-ID: <4D8B1641.6000706@grandegger.com> (raw)
In-Reply-To: <1300963120.3295.7.camel@localhost>

Hi Jan,

On 03/24/2011 11:38 AM, Jan Altenberg wrote:
> Hi Bhupesh,
> 
> as discussed I moved c_can_inval_msg_object() to the end of the if()
> statement. That should fix the tx_bytes accounting. For me it's working
> fine now.
> 
> Signed-off-by: Jan Altenberg <jan-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>
> ---

Could you please provide a proper commit message and put other comments
below "---".

Thanks,

Wolfgang.

  reply	other threads:[~2011-03-24 10:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 15:59 can: c_can: TX handling Jan Altenberg
2011-03-23  8:51 ` can: c_can: TX echo Kurt Van Dijck
2011-03-23 13:54   ` Jan Altenberg
2011-03-23 14:25     ` Wolfgang Grandegger
2011-03-23 14:52       ` Jan Altenberg
2011-03-23  8:53 ` can: c_can: TX delivery Kurt Van Dijck
2011-03-23 15:32   ` Jan Altenberg
2011-03-23 15:49     ` Kurt Van Dijck
2011-03-24 10:02     ` Marc Kleine-Budde
2011-03-24  4:18 ` c_can: TX handling Bhupesh SHARMA
2011-03-24 10:56   ` Jan Altenberg
2011-03-24  5:43 ` Bhupesh SHARMA
2011-03-24 10:38   ` [PATCH] can: c_can: Fix tx_bytes accounting Jan Altenberg
2011-03-24 10:00     ` Wolfgang Grandegger [this message]
2011-03-24 11:26       ` [PATCH resend] " Jan Altenberg
2011-03-24 10:49         ` Kurt Van Dijck
     [not found]           ` <20110324104925.GB339-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-03-24 11:49             ` Wolfgang Grandegger
     [not found]               ` <4D8B2FAF.5040000-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-03-28  1:24                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D8B1641.6000706@grandegger.com \
    --to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
    --cc=Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
    --cc=b.spranger-hfZtesqFncYOwBW4kG4KsQ@public$(echo .)gmane.org \
    --cc=jan-hfZtesqFncYOwBW4kG4KsQ@public$(echo .)gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox