From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: Jan Altenberg <jan-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>,
Bhupesh SHARMA <bhupesh.sharma-qxv4g6HH51o@public•gmane.org>,
"b.spranger-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org"
<b.spranger-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>, "
Subject: Re: [PATCH resend] can: c_can: Fix tx_bytes accounting
Date: Thu, 24 Mar 2011 12:49:03 +0100 [thread overview]
Message-ID: <4D8B2FAF.5040000@grandegger.com> (raw)
In-Reply-To: <20110324104925.GB339-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
On 03/24/2011 11:49 AM, Kurt Van Dijck wrote:
> On Thu, Mar 24, 2011 at 12:26:50PM +0100, Jan Altenberg wrote:
>> The current SocketCAN implementation for the Bosch c_can cell doesn't
>> account the TX bytes correctly, because it calls
>> c_can_inval_msg_object() (which clears the msg ctrl register) before
>> reading the DLC value:
>>
>> The fix is quite easy: Just move c_can_inval_msg_object() to the end of
>> the if() statement. So:
>> * We only call c_can_inval_msg_object() if the message was
>> actually transmitted
>> * We read out the DLC value _before_ clearing the msg ctrl
>> register
>>
>> Signed-off-by: Jan Altenberg <jan-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>
> Acked-by: Kurt Van Dijck <kurt.van.dijck-/BeEPy95v10@public•gmane.org>
Acked-by: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
next prev parent reply other threads:[~2011-03-24 11:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 15:59 can: c_can: TX handling Jan Altenberg
2011-03-23 8:51 ` can: c_can: TX echo Kurt Van Dijck
2011-03-23 13:54 ` Jan Altenberg
2011-03-23 14:25 ` Wolfgang Grandegger
2011-03-23 14:52 ` Jan Altenberg
2011-03-23 8:53 ` can: c_can: TX delivery Kurt Van Dijck
2011-03-23 15:32 ` Jan Altenberg
2011-03-23 15:49 ` Kurt Van Dijck
2011-03-24 10:02 ` Marc Kleine-Budde
2011-03-24 4:18 ` c_can: TX handling Bhupesh SHARMA
2011-03-24 10:56 ` Jan Altenberg
2011-03-24 5:43 ` Bhupesh SHARMA
2011-03-24 10:38 ` [PATCH] can: c_can: Fix tx_bytes accounting Jan Altenberg
2011-03-24 10:00 ` Wolfgang Grandegger
2011-03-24 11:26 ` [PATCH resend] " Jan Altenberg
2011-03-24 10:49 ` Kurt Van Dijck
[not found] ` <20110324104925.GB339-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-03-24 11:49 ` Wolfgang Grandegger [this message]
[not found] ` <4D8B2FAF.5040000-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-03-28 1:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8B2FAF.5040000@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
--cc=b.spranger-hfZtesqFncYOwBW4kG4KsQ@public$(echo .)gmane.org \
--cc=bhupesh.sharma-qxv4g6HH51o@public$(echo .)gmane.org \
--cc=jan-hfZtesqFncYOwBW4kG4KsQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox