From: Shan Wei <shanwei@cn•fujitsu.com>
To: Dimitris Michailidis <dm@chelsio•com>
Cc: David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>,
eilong@broadcom•com, leedom@chelsio•com
Subject: Re: [PATCH net-next 1/2 RESEND v3] net: use NETIF_F_ALL_TSO for vlan features
Date: Thu, 12 May 2011 17:54:03 +0800 [thread overview]
Message-ID: <4DCBAE3B.3070201@cn.fujitsu.com> (raw)
In-Reply-To: <4DCABABB.9040001@chelsio.com>
Dimitris Michailidis wrote, at 2011年05月12日 00:35:
> On 05/10/2011 11:24 PM, Shan Wei wrote:
>> As Dimitris Michailidis suggested, use NETIF_F_ALL_TSO for vlan_features,
>> which is a mask, but not hw_features.
>>
>> Signed-off-by: Shan Wei <shanwei@cn•fujitsu.com>
>
> While these changes aren't wrong I don't see a good reason to make them. I am also curious why you're changing only these three drivers.
A personal reason to quickly know what device supports ALL TSO,
not to search one by one. :;)
TSO offloads are assigned directly in these three drivers.
Other drivers set vlan_features as hw_features, or set TSO offloads after doing some check.
--
Best Regards
-----
Shan Wei
next prev parent reply other threads:[~2011-05-12 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4DCA2B86.9030205@cn.fujitsu.com>
2011-05-11 16:35 ` [PATCH net-next 1/2 RESEND v3] net: use NETIF_F_ALL_TSO for vlan features Dimitris Michailidis
2011-05-12 9:54 ` Shan Wei [this message]
2011-05-12 17:05 ` Dimitris Michailidis
2011-05-13 2:10 ` Shan Wei
2011-05-13 3:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCBAE3B.3070201@cn.fujitsu.com \
--to=shanwei@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=dm@chelsio$(echo .)com \
--cc=eilong@broadcom$(echo .)com \
--cc=leedom@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox