* Is skb->queue_mapping valid for received packets?
@ 2011-06-14 1:59 Ben Greear
2011-06-14 2:06 ` Ben Greear
2011-06-14 2:16 ` Andy Gospodarek
0 siblings, 2 replies; 5+ messages in thread
From: Ben Greear @ 2011-06-14 1:59 UTC (permalink / raw)
To: NetDev
Anyone know if skb->queue_mapping is set for incoming packets, ie to
notify which queue they came in on? I can't find it set anywhere,
and it appears it is sometimes set to 1 when it should be 0 in
my system.
Maybe it's never actually set, and I'm just reading some stale
data?
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Is skb->queue_mapping valid for received packets?
2011-06-14 1:59 Is skb->queue_mapping valid for received packets? Ben Greear
@ 2011-06-14 2:06 ` Ben Greear
2011-06-14 2:21 ` Andy Gospodarek
2011-06-14 2:16 ` Andy Gospodarek
1 sibling, 1 reply; 5+ messages in thread
From: Ben Greear @ 2011-06-14 2:06 UTC (permalink / raw)
To: NetDev
On 06/13/2011 06:59 PM, Ben Greear wrote:
>
> Anyone know if skb->queue_mapping is set for incoming packets, ie to
> notify which queue they came in on? I can't find it set anywhere,
> and it appears it is sometimes set to 1 when it should be 0 in
> my system.
>
> Maybe it's never actually set, and I'm just reading some stale
> data?
Bleh, found it the second I posted.
Seems it's skb_record_rx_queue(), and funny enough, it seems to add +1,
so if you are trying to bridge pkts from eth0 to eth1 on the same queues,
looks like you need to subtract one on xmit before finding the txqueue.
Or something like that.
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Is skb->queue_mapping valid for received packets?
2011-06-14 2:06 ` Ben Greear
@ 2011-06-14 2:21 ` Andy Gospodarek
2011-06-14 2:28 ` Ben Greear
0 siblings, 1 reply; 5+ messages in thread
From: Andy Gospodarek @ 2011-06-14 2:21 UTC (permalink / raw)
To: Ben Greear; +Cc: NetDev
On Mon, Jun 13, 2011 at 07:06:53PM -0700, Ben Greear wrote:
> On 06/13/2011 06:59 PM, Ben Greear wrote:
>>
>> Anyone know if skb->queue_mapping is set for incoming packets, ie to
>> notify which queue they came in on? I can't find it set anywhere,
>> and it appears it is sometimes set to 1 when it should be 0 in
>> my system.
>>
>> Maybe it's never actually set, and I'm just reading some stale
>> data?
>
> Bleh, found it the second I posted.
>
> Seems it's skb_record_rx_queue(), and funny enough, it seems to add +1,
> so if you are trying to bridge pkts from eth0 to eth1 on the same queues,
> looks like you need to subtract one on xmit before finding the txqueue.
>
> Or something like that.
>
Just saw your response after I replied. :-)
The queue_mapping storage is a bit odd, but it generally works. The
value stored in queue_mapping should be decremented properly in
dev_pick_tx and it should go out of your card with a tx queue that
matches the rx queue.
There were some issues discovered and fixed with bonding last week
related to queue_mapping and I would not be surprised if another stacked
interface like bridging had an issue.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Is skb->queue_mapping valid for received packets?
2011-06-14 2:21 ` Andy Gospodarek
@ 2011-06-14 2:28 ` Ben Greear
0 siblings, 0 replies; 5+ messages in thread
From: Ben Greear @ 2011-06-14 2:28 UTC (permalink / raw)
To: Andy Gospodarek; +Cc: NetDev
On 06/13/2011 07:21 PM, Andy Gospodarek wrote:
> On Mon, Jun 13, 2011 at 07:06:53PM -0700, Ben Greear wrote:
>> On 06/13/2011 06:59 PM, Ben Greear wrote:
>>>
>>> Anyone know if skb->queue_mapping is set for incoming packets, ie to
>>> notify which queue they came in on? I can't find it set anywhere,
>>> and it appears it is sometimes set to 1 when it should be 0 in
>>> my system.
>>>
>>> Maybe it's never actually set, and I'm just reading some stale
>>> data?
>>
>> Bleh, found it the second I posted.
>>
>> Seems it's skb_record_rx_queue(), and funny enough, it seems to add +1,
>> so if you are trying to bridge pkts from eth0 to eth1 on the same queues,
>> looks like you need to subtract one on xmit before finding the txqueue.
>>
>> Or something like that.
>>
>
> Just saw your response after I replied. :-)
>
> The queue_mapping storage is a bit odd, but it generally works. The
> value stored in queue_mapping should be decremented properly in
> dev_pick_tx and it should go out of your card with a tx queue that
> matches the rx queue.
>
> There were some issues discovered and fixed with bonding last week
> related to queue_mapping and I would not be surprised if another stacked
> interface like bridging had an issue.
I feel a bit better that I'm not the only one who got
confused on this :)
A quick grep didn't show any queue mgt in bridging code, but
I didn't look closely and might have grep'd the wrong thing.
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Is skb->queue_mapping valid for received packets?
2011-06-14 1:59 Is skb->queue_mapping valid for received packets? Ben Greear
2011-06-14 2:06 ` Ben Greear
@ 2011-06-14 2:16 ` Andy Gospodarek
1 sibling, 0 replies; 5+ messages in thread
From: Andy Gospodarek @ 2011-06-14 2:16 UTC (permalink / raw)
To: Ben Greear; +Cc: NetDev
On Mon, Jun 13, 2011 at 06:59:45PM -0700, Ben Greear wrote:
>
> Anyone know if skb->queue_mapping is set for incoming packets, ie to
> notify which queue they came in on? I can't find it set anywhere,
> and it appears it is sometimes set to 1 when it should be 0 in
> my system.
>
> Maybe it's never actually set, and I'm just reading some stale
> data?
>
> Thanks,
> Ben
Yes, it is set by calls to skb_record_rx_queue in various multiqueue-
capable ethernet drivers. Where are you checking it and seeing the
incorrect value?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-06-14 2:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-14 1:59 Is skb->queue_mapping valid for received packets? Ben Greear
2011-06-14 2:06 ` Ben Greear
2011-06-14 2:21 ` Andy Gospodarek
2011-06-14 2:28 ` Ben Greear
2011-06-14 2:16 ` Andy Gospodarek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox