From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail•com>
To: Jiri Pirko <jpirko@redhat•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
shemminger@linux-foundation•org, kaber@trash•net,
fubar@us•ibm.com, eric.dumazet@gmail•com, andy@greyhouse•net,
Ben Greear <greearb@candelatech•com>
Subject: Re: [RFC patch net-next-2.6] net: allow multiple rx_handler registration
Date: Thu, 30 Jun 2011 21:50:52 +0200 [thread overview]
Message-ID: <4E0CD39C.8060209@gmail.com> (raw)
In-Reply-To: <1309447009-8898-1-git-send-email-jpirko@redhat.com>
Le 30/06/2011 17:16, Jiri Pirko a écrit :
> For some net topos it is necessary to have multiple "soft-net-devices"
> hooked on one netdev. For example very common is to have
> eth<->(br+vlan). Vlan is not using rh_handler (yet) but also for example
> macvlan would be useful to have hooked on same netdev as br.
>
> This patch introduces rx_handler list. size struct net_device stays
> intact. Measured performance regression on eth-br topo is ~1% (on received
> pkts generated by pktgen) and on eth-bond topo it is ~0.25%
>
> On br I think that the performance can be brought back maybe by using per-cpu
> variables to store port in rx_path (I must check this)
>
> Please comment.
>
> Signed-off-by: Jiri Pirko<jpirko@redhat•com>
I like the idea of this patch.
I didn't take time for a technical review yet, but I'm not sure ordering should be static, depending
on the kind of device (bond, br, macvlan). Ordering is currently static, because it is hard coded.
I think rx_handler_prio should be exposed to userspace, to allow user setup to decide the exact
order. Default order should be safe, but user should be allowed to force a different order for
special setups.
Nicolas.
next prev parent reply other threads:[~2011-06-30 19:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 15:16 [RFC patch net-next-2.6] net: allow multiple rx_handler registration Jiri Pirko
2011-06-30 16:27 ` Stephen Hemminger
2011-06-30 17:22 ` Jiri Pirko
2011-06-30 17:29 ` Ben Greear
2011-06-30 17:32 ` Jiri Pirko
2011-07-01 6:36 ` Michał Mirosław
2011-07-01 14:57 ` Nicolas de Pesloüan
2011-07-01 15:00 ` Jiri Pirko
2011-07-01 15:01 ` Michał Mirosław
2011-07-01 16:45 ` Nicolas de Pesloüan
2011-07-01 16:49 ` Ben Greear
2011-07-01 16:58 ` Nicolas de Pesloüan
2011-07-01 17:08 ` David Lamparter
2011-07-01 17:50 ` Michał Mirosław
2011-06-30 18:13 ` Ben Greear
2011-06-30 18:28 ` Jiri Pirko
2011-06-30 18:53 ` Ben Greear
2011-06-30 19:50 ` Nicolas de Pesloüan [this message]
2011-07-01 5:45 ` Jiri Pirko
2011-07-01 16:55 ` David Lamparter
2011-07-01 12:48 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0CD39C.8060209@gmail.com \
--to=nicolas.2p.debian@gmail$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=greearb@candelatech$(echo .)com \
--cc=jpirko@redhat$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox