From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail•com>
To: Ben Greear <greearb@candelatech•com>
Cc: "Michał Mirosław" <mirqus@gmail•com>,
"Jiri Pirko" <jpirko@redhat•com>,
"Stephen Hemminger" <shemminger@vyatta•com>,
netdev@vger•kernel.org, davem@davemloft•net, kaber@trash•net,
fubar@us•ibm.com, eric.dumazet@gmail•com, andy@greyhouse•net
Subject: Re: [RFC patch net-next-2.6] net: allow multiple rx_handler registration
Date: Fri, 01 Jul 2011 18:58:41 +0200 [thread overview]
Message-ID: <4E0DFCC1.1050409@gmail.com> (raw)
In-Reply-To: <4E0DFA7F.20005@candelatech.com>
Le 01/07/2011 18:49, Ben Greear a écrit :
> On 07/01/2011 09:45 AM, Nicolas de Pesloüan wrote:
>> Le 01/07/2011 17:01, Michał Mirosław a écrit :
>>
>>>>> We could introduce a catch-all macvlan/vlan device that would take
>>>>> addresses/VLANs which are not covered by other configured
>>>>> macvlans/vlans. This would allow clearer configuration and would make
>>>>> the evaluation order explicit. As a bonus, this will give another
>>>>> device to put tcpdump on. ;-)
>>>>
>>>> 'Sounds like what I had in mind in
>>>> http://marc.info/?l=linux-netdev&m=130622112921245&w=2 .
>>>
>>> Almost. My idea assumes that eth0.any won't strip VLAN headers (so its
>>> just looks like a filtered eth0).
>>
>> I originally thought unstripped packets should go to eth0.
>>
>> But, if eth0.any get untagged packets, we face two problems:
>>
>> 1/ We need a way to retrieve the original tag.
>> 2/ We need a way to force the tag on output (or we consider eth0.any a
>> pure tcpdump device, which is less useful).
>>
>> But if eth0.any get the exact same packets as those delivered to eth0,
>> this seems useless.
>>
>> Or maybe, eth0.any should get only packets that weren't delivered to any
>> eth0.XXXX devices... and should be named eth0.unmatched instead of
>> eth0.any :-)
>>
>> Do we need eth0.untagged too (which would only get packets that were
>> originally *not* tagged)?
>>
>> eth0 - Get everything, untouched. (I know several people except tagged
>> packets to be untagged here, but I disagree with this part. eth0 is the
>> raw device and should deliver raw packets, possibly retagging packets
>> that were untagged by hw-accel).
>> eth0.100 - Get VLAN 100 packet, untagged.
>> eth0.untagged - Get only non-tagged packets, untouched.
>> eth0.unmatched - Get only tagged packets, untouched.
>
> Lets let the current vlan tagging changes settle a while before
> adding yet more cruft in this area.
Agreed.
> Packet filters should be able to filter on tags or not, so I don't
> think these extra interfaces would be useful or needed. We may
> need to fix up the sk-filter logic a bit to deal with the
> stripped tags, however.
Agreed too.
Nicolas.
next prev parent reply other threads:[~2011-07-01 16:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 15:16 [RFC patch net-next-2.6] net: allow multiple rx_handler registration Jiri Pirko
2011-06-30 16:27 ` Stephen Hemminger
2011-06-30 17:22 ` Jiri Pirko
2011-06-30 17:29 ` Ben Greear
2011-06-30 17:32 ` Jiri Pirko
2011-07-01 6:36 ` Michał Mirosław
2011-07-01 14:57 ` Nicolas de Pesloüan
2011-07-01 15:00 ` Jiri Pirko
2011-07-01 15:01 ` Michał Mirosław
2011-07-01 16:45 ` Nicolas de Pesloüan
2011-07-01 16:49 ` Ben Greear
2011-07-01 16:58 ` Nicolas de Pesloüan [this message]
2011-07-01 17:08 ` David Lamparter
2011-07-01 17:50 ` Michał Mirosław
2011-06-30 18:13 ` Ben Greear
2011-06-30 18:28 ` Jiri Pirko
2011-06-30 18:53 ` Ben Greear
2011-06-30 19:50 ` Nicolas de Pesloüan
2011-07-01 5:45 ` Jiri Pirko
2011-07-01 16:55 ` David Lamparter
2011-07-01 12:48 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0DFCC1.1050409@gmail.com \
--to=nicolas.2p.debian@gmail$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=greearb@candelatech$(echo .)com \
--cc=jpirko@redhat$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=mirqus@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox