* [PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast. @ 2011-09-23 23:11 greearb 2011-09-27 19:34 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: greearb @ 2011-09-23 23:11 UTC (permalink / raw) To: netdev; +Cc: Ben Greear From: Ben Greear <greearb@candelatech•com> If reg_vif_xmit cannot find a routing entry, be sure to free the skb before returning the error. Signed-off-by: Ben Greear <greearb@candelatech•com> --- :100644 100644 82a8099... e9a8df9... M net/ipv6/ip6mr.c net/ipv6/ip6mr.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index 82a8099..e9a8df9 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -696,8 +696,10 @@ static netdev_tx_t reg_vif_xmit(struct sk_buff *skb, int err; err = ip6mr_fib_lookup(net, &fl6, &mrt); - if (err < 0) + if (err < 0) { + kfree_skb(skb); return err; + } read_lock(&mrt_lock); dev->stats.tx_bytes += skb->len; -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast. 2011-09-23 23:11 [PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast greearb @ 2011-09-27 19:34 ` David Miller 2012-02-02 17:27 ` Ben Greear 0 siblings, 1 reply; 3+ messages in thread From: David Miller @ 2011-09-27 19:34 UTC (permalink / raw) To: greearb; +Cc: netdev From: greearb@candelatech•com Date: Fri, 23 Sep 2011 16:11:01 -0700 > From: Ben Greear <greearb@candelatech•com> > > If reg_vif_xmit cannot find a routing entry, be sure to > free the skb before returning the error. > > Signed-off-by: Ben Greear <greearb@candelatech•com> Applied. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast. 2011-09-27 19:34 ` David Miller @ 2012-02-02 17:27 ` Ben Greear 0 siblings, 0 replies; 3+ messages in thread From: Ben Greear @ 2012-02-02 17:27 UTC (permalink / raw) To: David Miller; +Cc: netdev On 09/27/2011 12:34 PM, David Miller wrote: > From: greearb@candelatech•com > Date: Fri, 23 Sep 2011 16:11:01 -0700 > >> From: Ben Greear<greearb@candelatech•com> >> >> If reg_vif_xmit cannot find a routing entry, be sure to >> free the skb before returning the error. >> >> Signed-off-by: Ben Greear<greearb@candelatech•com> > > Applied. This one has not made it to 3.0 stable either. Ben -- Ben Greear <greearb@candelatech•com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-02 17:27 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-09-23 23:11 [PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast greearb 2011-09-27 19:34 ` David Miller 2012-02-02 17:27 ` Ben Greear
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox