From: Bryan Schumaker <bjschuma-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
To: "Myklebust,
Trond" <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
Cc: Stanislav Kinsbursky
<skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>,
"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Pavel Emelianov <xemul-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>,
"neilb-l3A5Bk7waGM@public•gmane.org"
<neilb-l3A5Bk7waGM@public•gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
James Bottomley
<jbottomley-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>,
"bfields-uC3wQj2KruNg9hUCZPvPmw@public•gmane.org"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public•gmane.org>,
"davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
"devel-GEFAQzZX7r8dnm+yROfE0A@public•gmane.org"
<devel-GEFAQzZX7r8dnm+yROfE0A@public•gmane.org>
Subject: Re: [PATCH 4/4] NFS: make nfs_client_lock per net ns
Date: Tue, 07 Feb 2012 09:30:45 -0500 [thread overview]
Message-ID: <4F313595.7090004@netapp.com> (raw)
In-Reply-To: <1328623906.4124.10.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
On 02/07/12 09:11, Myklebust, Trond wrote:
> On Tue, 2012-02-07 at 18:09 +0400, Stanislav Kinsbursky wrote:
>> 07.02.2012 17:51, Myklebust, Trond пишет:
>>> 8<-------------------------------------------------------------------------
>>> From 5a489156da4fd15dd143f2b21dd9657b97dcef88 Mon Sep 17 00:00:00 2001
>>> From: Trond Myklebust<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
>>> Date: Tue, 7 Feb 2012 00:05:11 -0500
>>> Subject: [PATCH] NFS: Initialise the nfs_net->nfs_client_lock
>>>
>>> Ensure that we initialise the nfs_net->nfs_client_lock spinlock.
>>> Also ensure that nfs_server_remove_lists() doesn't try to
>>> dereference server->nfs_client before that is initialised.
>>>
>>
>> Sorry.
>> Patch looks nice. Except one notice below.
>>
>>> Signed-off-by: Trond Myklebust<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
>>> Cc: Stanislav Kinsbursky<skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>
>>> ---
>>> fs/nfs/client.c | 6 +++++-
>>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
>>> index 1a5cd49..f0dacad 100644
>>> --- a/fs/nfs/client.c
>>> +++ b/fs/nfs/client.c
>>> @@ -1055,8 +1055,11 @@ static void nfs_server_insert_lists(struct nfs_server *server)
>>> static void nfs_server_remove_lists(struct nfs_server *server)
>>> {
>>> struct nfs_client *clp = server->nfs_client;
>>> - struct nfs_net *nn = net_generic(clp->net, nfs_net_id);
>>> + struct nfs_net *nn;
>>>
>>> + if (clp == NULL)
>>> + return;
>>> + nn = net_generic(clp->net, nfs_net_id);
>>> spin_lock(&nn->nfs_client_lock);
>>> list_del_rcu(&server->client_link);
>>> if (clp&& list_empty(&clp->cl_superblocks))
>>
>> This check for clp != NULL can be removed.
>>
>
> Yep... I'll add that in...
When I compile Trond's devel branch I get this:
make[1]: Nothing to be done for `all'.
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CHK kernel/config_data.h
CC [M] fs/nfs/idmap.o
fs/nfs/idmap.c: In function 'rpc_pipefs_event':
fs/nfs/idmap.c:535:9: error: implicit declaration of function 'net_generic' [-Werror=implicit-function-declaration]
fs/nfs/idmap.c:535:50: error: 'nfs_net_id' undeclared (first use in this function)
fs/nfs/idmap.c:535:50: note: each undeclared identifier is reported only once for each function it appears in
fs/nfs/idmap.c:540:82: error: dereferencing pointer to incomplete type
fs/nfs/idmap.c:540:224: error: dereferencing pointer to incomplete type
cc1: some warnings being treated as errors
make[2]: *** [fs/nfs/idmap.o] Error 1
make[1]: *** [fs/nfs] Error 2
make: *** [fs] Error 2
I bisected it to this patch, probably a missing #include?
- Bryan
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-07 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:25 [PATCH 0/4] NFS: make internal list network namespace aware Stanislav Kinsbursky
2012-01-23 17:26 ` [PATCH 1/4] NFS: make nfs_client_list per net ns Stanislav Kinsbursky
2012-02-07 15:32 ` Bryan Schumaker
[not found] ` <4F3143F4.3010502-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
2012-02-07 15:34 ` Myklebust, Trond
2012-02-07 15:44 ` Bryan Schumaker
2012-01-23 17:26 ` [PATCH 2/4] NFS: make nfs_volume_list " Stanislav Kinsbursky
[not found] ` <20120123171404.29637.19810.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-01-23 17:26 ` [PATCH 3/4] NFS: make cb_ident_idr " Stanislav Kinsbursky
2012-01-23 17:26 ` [PATCH 4/4] NFS: make nfs_client_lock " Stanislav Kinsbursky
[not found] ` <20120123172631.29637.17188.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-02-07 13:51 ` Myklebust, Trond
2012-02-07 14:09 ` Stanislav Kinsbursky
[not found] ` <4F31308B.1090002-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-02-07 14:11 ` Myklebust, Trond
[not found] ` <1328623906.4124.10.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2012-02-07 14:30 ` Bryan Schumaker [this message]
[not found] ` <4F313595.7090004-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
2012-02-07 14:35 ` Bryan Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F313595.7090004@netapp.com \
--to=bjschuma-hgovqubeegtqt0dzr+alfa@public$(echo .)gmane.org \
--cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=devel-GEFAQzZX7r8dnm+yROfE0A@public$(echo .)gmane.org \
--cc=jbottomley-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=neilb-l3A5Bk7waGM@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
--cc=xemul-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox