From: Bryan Schumaker <bjschuma@netapp•com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp•com>
Cc: "Schumaker, Bryan" <Bryan.Schumaker@netapp•com>,
Stanislav Kinsbursky <skinsbursky@parallels•com>,
"linux-nfs@vger•kernel.org" <linux-nfs@vger•kernel.org>,
"xemul@parallels•com" <xemul@parallels•com>,
"neilb@suse•de" <neilb@suse•de>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"jbottomley@parallels•com" <jbottomley@parallels•com>,
"bfields@fieldses•org" <bfields@fieldses•org>,
"davem@davemloft•net" <davem@davemloft•net>,
"devel@openvz•org" <devel@openvz•org>
Subject: Re: [PATCH 1/4] NFS: make nfs_client_list per net ns
Date: Tue, 07 Feb 2012 10:44:32 -0500 [thread overview]
Message-ID: <4F3146E0.4040704@netapp.com> (raw)
In-Reply-To: <1328628888.4124.16.camel@lade.trondhjem.org>
On 02/07/12 10:34, Myklebust, Trond wrote:
> On Tue, 2012-02-07 at 10:32 -0500, Bryan Schumaker wrote:
>> I fixed up my bisect and identified this patch instead. The problem I'm seeing is:
>>
>> CC [M] fs/nfs/delegation.o
>> CC [M] fs/nfs/idmap.o
>> fs/nfs/idmap.c: In function 'rpc_pipefs_event':
>> fs/nfs/idmap.c:535:9: error: implicit declaration of function 'net_generic' [-Werror=implicit-function-declaration]
>> fs/nfs/idmap.c:535:50: error: 'nfs_net_id' undeclared (first use in this function)
>> fs/nfs/idmap.c:535:50: note: each undeclared identifier is reported only once for each function it appears in
>> fs/nfs/idmap.c:540:82: error: dereferencing pointer to incomplete type
>> fs/nfs/idmap.c:540:224: error: dereferencing pointer to incomplete type
>> cc1: some warnings being treated as errors
>>
>> make[2]: *** [fs/nfs/idmap.o] Error 1
>> make[1]: *** [fs/nfs] Error 2
>> make: *** [fs] Error 2
>>
>> I think you need to add: #include "netns.h" to idmap.c.
>>
>> - Bryan
>
> That should already be there in the 'devel' branch. See commit
> 17347d03c008e2f504c33bb4905cdad0abc01319.
>
Yes, but once I fixed this I was able to find the initial problem I was searching for (I have no idea how git led me to the wrong patch on my first attempt).
- Bryan
next prev parent reply other threads:[~2012-02-07 15:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:25 [PATCH 0/4] NFS: make internal list network namespace aware Stanislav Kinsbursky
2012-01-23 17:26 ` [PATCH 1/4] NFS: make nfs_client_list per net ns Stanislav Kinsbursky
2012-02-07 15:32 ` Bryan Schumaker
[not found] ` <4F3143F4.3010502-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
2012-02-07 15:34 ` Myklebust, Trond
2012-02-07 15:44 ` Bryan Schumaker [this message]
2012-01-23 17:26 ` [PATCH 2/4] NFS: make nfs_volume_list " Stanislav Kinsbursky
[not found] ` <20120123171404.29637.19810.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-01-23 17:26 ` [PATCH 3/4] NFS: make cb_ident_idr " Stanislav Kinsbursky
2012-01-23 17:26 ` [PATCH 4/4] NFS: make nfs_client_lock " Stanislav Kinsbursky
[not found] ` <20120123172631.29637.17188.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-02-07 13:51 ` Myklebust, Trond
2012-02-07 14:09 ` Stanislav Kinsbursky
[not found] ` <4F31308B.1090002-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-02-07 14:11 ` Myklebust, Trond
[not found] ` <1328623906.4124.10.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2012-02-07 14:30 ` Bryan Schumaker
[not found] ` <4F313595.7090004-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
2012-02-07 14:35 ` Bryan Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3146E0.4040704@netapp.com \
--to=bjschuma@netapp$(echo .)com \
--cc=Bryan.Schumaker@netapp$(echo .)com \
--cc=Trond.Myklebust@netapp$(echo .)com \
--cc=bfields@fieldses$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devel@openvz$(echo .)org \
--cc=jbottomley@parallels$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=skinsbursky@parallels$(echo .)com \
--cc=xemul@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox