From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, francesco.virlinzi@st•com
Subject: Re: [PATCH 1/2] stmmac: request_irq when use an ext wake irq line
Date: Fri, 10 Feb 2012 07:31:21 +0100 [thread overview]
Message-ID: <4F34B9B9.5090803@st.com> (raw)
In-Reply-To: <20120209.140251.1155907203355431647.davem@davemloft.net>
On 2/9/2012 8:02 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
> Date: Thu, 9 Feb 2012 08:55:13 +0100
>
>> From: Francesco Virlinzi <francesco.virlinzi@st•com>
>>
>> In case of we use an external Wake-Up IRQ line
>> (priv->wol_irq != dev->irq) we need to invoke the
>> request_irq.
>>
>> Signed-off-by: Francesco Virlinzi <francesco.virlinzi@st•com>
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st•com>
>
> You never free the IRQ in the driver close path, so it leaks.
Yes you are right. I'm reviewing the patch and send it again.
Thx
peppe
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2012-02-10 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 7:55 [PATCH 1/2] stmmac: request_irq when use an ext wake irq line Giuseppe CAVALLARO
2012-02-09 7:55 ` [PATCH 2/2] stmmac: do not discard frame on dribbling bit assert Giuseppe CAVALLARO
2012-02-09 19:02 ` [PATCH 1/2] stmmac: request_irq when use an ext wake irq line David Miller
2012-02-10 6:31 ` Giuseppe CAVALLARO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F34B9B9.5090803@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=francesco.virlinzi@st$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox