From: Ben Greear <greearb@candelatech•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>,
NetDev <netdev@vger•kernel.org>,
Mihai Maruseac <mmaruseac@ixiacom•com>
Subject: Re: [PATCH net: fix /proc/net/dev regression
Date: Tue, 03 Apr 2012 08:36:48 -0700 [thread overview]
Message-ID: <4F7B1910.3010701@candelatech.com> (raw)
In-Reply-To: <1333441982.18626.62.camel@edumazet-glaptop>
On 04/03/2012 01:33 AM, Eric Dumazet wrote:
> Commit f04565ddf52 (dev: use name hash for dev_seq_ops) added a second
> regression, as some devices are missing from /proc/net/dev if many
> devices are defined.
>
> When seq_file buffer is filled, the last ->next/show() method is
> canceled (pos value is reverted to value prior ->next() call)
>
> Problem is after above commit, we dont restart the lookup at right
> position in ->start() method.
>
> Fix this by removing the internal 'pos' pointer added in commit, since
> we need to use the 'loff_t *pos' provided by seq_file layer.
>
> This also reverts commit 5cac98dd0 (net: Fix corruption
> in /proc/*/net/dev_mcast), since its not needed anymore.
>
> Reported-by: Ben Greear<greearb@candelatech•com>
> Signed-off-by: Eric Dumazet<eric.dumazet@gmail•com>
> Cc: Mihai Maruseac<mmaruseac@ixiacom•com>
This appears to fix the problem. I do find it mildly irritating
that the ordering is now random in /proc/net/dev, but I guess
that is the price of progress.
Tested-by: Ben Greear <greearb@candelatech•com>
Thanks for the quick fix!
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-04-03 15:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 4:29 /proc/net/dev is funky in 3.3.0 Ben Greear
2012-04-03 5:43 ` Eric Dumazet
2012-04-03 5:53 ` Ben Greear
2012-04-03 6:36 ` Eric Dumazet
2012-04-03 7:06 ` Eric Dumazet
2012-04-03 7:17 ` Mihai Maruseac
2012-04-03 8:33 ` [PATCH net: fix /proc/net/dev regression Eric Dumazet
2012-04-03 15:36 ` Ben Greear [this message]
2012-04-03 15:59 ` Eric Dumazet
2012-04-03 21:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7B1910.3010701@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=mmaruseac@ixiacom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox