From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: Bob Liu <lliubbo@gmail•com>
Cc: davem@davemloft•net, francesco.virlinzi@st•com,
rayagond@vayavyalabs•com, sr@denx•de, netdev@vger•kernel.org,
uclinux-dist-devel@blackfin•uclinux.org
Subject: Re: [PATCH 2/3] drivers: net: ethernet: stmmac: fix failure in module test
Date: Tue, 22 May 2012 14:51:09 +0200 [thread overview]
Message-ID: <4FBB8BBD.8010208@st.com> (raw)
In-Reply-To: <1337672336-7378-2-git-send-email-lliubbo@gmail.com>
On 5/22/2012 9:38 AM, Bob Liu wrote:
> Module can't be compiled and installed in current Makefile.
I've just seen that I can generate the stmmac.ko on ARM and also on x86
with my configuration.
Can you post here you build failure?
In the meantime I'll test the module on ARM soon.
peppe
>
> Signed-off-by: Bob Liu <lliubbo@gmail•com>
> ---
> drivers/net/ethernet/stmicro/stmmac/Makefile | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Makefile b/drivers/net/ethernet/stmicro/stmmac/Makefile
> index bc965ac..4b50922 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Makefile
> +++ b/drivers/net/ethernet/stmicro/stmmac/Makefile
> @@ -1,10 +1,10 @@
> obj-$(CONFIG_STMMAC_ETH) += stmmac.o
> -stmmac-$(CONFIG_STMMAC_TIMER) += stmmac_timer.o
> -stmmac-$(CONFIG_STMMAC_RING) += ring_mode.o
> -stmmac-$(CONFIG_STMMAC_CHAINED) += chain_mode.o
> -stmmac-$(CONFIG_STMMAC_PLATFORM) += stmmac_platform.o
> -stmmac-$(CONFIG_STMMAC_PCI) += stmmac_pci.o
> +stmmac-$(CONFIG_STMMAC_TIMER:m=y) += stmmac_timer.o
> +stmmac-$(CONFIG_STMMAC_RING:m=y) += ring_mode.o
> +stmmac-$(CONFIG_STMMAC_CHAINED:m=y) += chain_mode.o
> +stmmac-$(CONFIG_STMMAC_PLATFORM:m=y) += stmmac_platform.o
> +stmmac-$(CONFIG_STMMAC_PCI:m=y) += stmmac_pci.o
> stmmac-objs:= stmmac_main.o stmmac_ethtool.o stmmac_mdio.o \
> dwmac_lib.o dwmac1000_core.o dwmac1000_dma.o \
> dwmac100_core.o dwmac100_dma.o enh_desc.o norm_desc.o \
> - mmc_core.o $(stmmac-y)
> + mmc_core.o
next prev parent reply other threads:[~2012-05-22 12:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 7:38 [PATCH 1/3] drivers: net: stmmac: add blackfin support Bob Liu
2012-05-22 7:38 ` [PATCH 2/3] drivers: net: ethernet: stmmac: fix failure in module test Bob Liu
2012-05-22 11:56 ` Ben Hutchings
2012-05-22 12:51 ` Giuseppe CAVALLARO [this message]
2012-05-23 5:09 ` Bob Liu
2012-05-23 6:08 ` Giuseppe CAVALLARO
2012-05-23 6:05 ` [net] stmmac: fix driver Kconfig when built as module Giuseppe CAVALLARO
2012-05-23 18:01 ` David Miller
2012-05-28 5:44 ` Giuseppe CAVALLARO
2012-05-22 7:38 ` [PATCH 3/3] drivers: net: ethernet: stmmac: fix resume function Bob Liu
2012-05-22 12:36 ` [PATCH 1/3] drivers: net: stmmac: add blackfin support Giuseppe CAVALLARO
2012-05-23 7:58 ` Bob Liu
2012-05-23 8:21 ` Giuseppe CAVALLARO
2012-05-23 8:27 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBB8BBD.8010208@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=francesco.virlinzi@st$(echo .)com \
--cc=lliubbo@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rayagond@vayavyalabs$(echo .)com \
--cc=sr@denx$(echo .)de \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox