From: Jan Ceuleers <jan.ceuleers@computer•org>
To: Steven King <sfking@fdwdc•com>
Cc: netdev@vger•kernel.org,
uClinux development list <uclinux-dev@uclinux•org>,
Greg Ungerer <gerg@snapgear•com>
Subject: Re: [PATCH net-next] fec: Add support for Coldfire M5441x enet-mac.
Date: Wed, 06 Jun 2012 19:34:21 +0200 [thread overview]
Message-ID: <4FCF949D.7060402@computer.org> (raw)
In-Reply-To: <201206061006.21288.sfking@fdwdc.com>
On 06/06/2012 07:06 PM, Steven King wrote:
> Add support for the Freescale Coldfire M5441x; as these parts have an
> enet-mac, add a quirk to distinguish them from the other Coldfire parts so we
> can use the existing enet-mac support.
Stephen,
You are activating certain functionality based on whether M5441x is
defined. But where is this being defined? Should this not be added in a
Kconfig somewhere as a platform option?
Thanks, Jan
next prev parent reply other threads:[~2012-06-06 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 17:06 [PATCH net-next] fec: Add support for Coldfire M5441x enet-mac Steven King
2012-06-06 17:34 ` Jan Ceuleers [this message]
2012-06-06 20:05 ` Steven King
2012-06-07 21:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF949D.7060402@computer.org \
--to=jan.ceuleers@computer$(echo .)org \
--cc=gerg@snapgear$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfking@fdwdc$(echo .)com \
--cc=uclinux-dev@uclinux$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox