From: Or Gerlitz <ogerlitz@mellanox•com>
To: Kleber Sacilotto de Souza <klebers@linux•vnet.ibm.com>
Cc: David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>,
<jackm@dev•mellanox.co.il>, <yevgenyp@mellanox•co.il>,
<cascardo@linux•vnet.ibm.com>, <brking@linux•vnet.ibm.com>,
<shlomop@mellanox•com>
Subject: Re: [PATCH] mlx4: Add support for EEH error recovery
Date: Mon, 23 Jul 2012 16:45:19 +0300 [thread overview]
Message-ID: <500D556F.4000409@mellanox.com> (raw)
In-Reply-To: <500D4F31.9020408@linux.vnet.ibm.com>
On 7/23/2012 4:18 PM, Kleber Sacilotto de Souza wrote:
> Exactly. The callbacks implemented are from standard PCI error recovery
> (Documentation/PCI/pci-error-recovery.txt) and the changes doesn't
> assume any platform in specific. The code was tested only on powerpc
> systems [...]
So how did you test that? using the kernel provided error injection
support and user space tool (which?) or in another way? we've trying
quickly here to inject errors using /sbin/ear-inject from
ras-utils-6.1-1.el6.x86_64 on a kernel built with
CONFIG_PCIEAER=y
CONFIG_PCIEAER_INJECT=m
and it failed to inject errors, SB details.
Or.
> since I don't have any mlx4 card on other platforms, however,
> these changes shouldn't make the error recover any worse than the
> current state.
> # lspci | grep 08.00.1
> 08:00.1 Ethernet controller: Intel Corporation 82575EB Gigabit Network
> Connection (rev 02)
> # cat /tmp/intel.aer
> AER
> BUS 8 DEV 0 FN 1
> COR_STATUS BAD_TLP
> HEADER_LOG 0 1 2 3
> # /sbin/aer-inject < /tmp/intel.aer
> Error: Failed to write, Invalid argument
> # strace -F -f /sbin/aer-inject < /tmp/intel.aer
> [...]
> open("/dev/aer_inject", O_WRONLY) = 3
> write(3, "\10\0\1\0\0\0\0\0@\0\0\0\0\0\0\0\1\0\0\0\2\0\0\0\3\0\0\0",
> 28) = -1 EINVAL (Invalid argument)
> write(2, "Error: ", 7Error: ) = 7
> write(2, "Failed to write", 15Failed to write) = 15
> write(2, ", Invalid argument\n", 19, Invalid argument
> ) = 19
> exit_group(-1) = ?
next prev parent reply other threads:[~2012-07-23 14:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 19:55 [PATCH] mlx4: Add support for EEH error recovery Kleber Sacilotto de Souza
2012-07-22 10:29 ` Or Gerlitz
[not found] ` <500BD558.2060803@mellanox.com>
2012-07-23 0:15 ` David Miller
2012-07-23 13:18 ` Kleber Sacilotto de Souza
2012-07-23 13:45 ` Or Gerlitz [this message]
2012-07-23 18:12 ` Kleber Sacilotto de Souza
2012-07-23 20:53 ` Kleber Sacilotto de Souza
2012-07-23 21:26 ` Or Gerlitz
2012-07-23 21:34 ` David Miller
2012-07-23 21:42 ` Or Gerlitz
2012-07-23 21:44 ` David Miller
2012-07-23 22:02 ` Or Gerlitz
2012-07-23 22:21 ` David Miller
2012-07-24 13:12 ` Kleber Sacilotto de Souza
2012-07-24 17:09 ` Shlomo Pongartz
2012-07-24 17:35 ` Kleber Sacilotto de Souza
2012-07-24 18:08 ` Thadeu Lima de Souza Cascardo
2012-07-24 18:35 ` Shlomo Pongratz
2012-07-24 18:39 ` Shlomo Pongratz
2012-07-24 21:03 ` David Miller
2012-07-24 22:30 ` Or Gerlitz
2012-07-25 14:38 ` Shlomo Pongartz
[not found] ` <5010070B.5040405@mellanox.com>
2012-07-25 15:02 ` Kleber Sacilotto de Souza
2012-07-25 22:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500D556F.4000409@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=cascardo@linux$(echo .)vnet.ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=jackm@dev$(echo .)mellanox.co.il \
--cc=klebers@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shlomop@mellanox$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox